Don't sort array when key is empty (#386)

Author: GavinJoyce

addon/helpers/sort-by.js

@@ -1,4 +1,5 @@
 import { get } from '@ember/object';
+import { isEmpty } from '@ember/utils';
 import { helper } from '@ember/component/helper';
 
 function normalizeToBoolean(val) {
@@ -18,6 +19,10 @@ function normalizeToBoolean(val) {
 }
 
 function sortDesc(key, a, b) {
+  if (isEmpty(key)) {
+    return 0;
+  }
+
   const aValue = get(a, key);
   const bValue = get(b, key);
 
@@ -44,6 +49,10 @@ function sortDesc(key, a, b) {
 }
 
 function sortAsc(key, a, b) {
+  if (isEmpty(key)) {
+    return 0;
+  }
+
   const aValue = get(a, key);
   const bValue = get(b, key);
 

tests/integration/helpers/sort-by-test.js

@@ -164,6 +164,22 @@ module('Integration | Helper | {{sort-by}}', function(hooks) {
     assert.equal(find('*').textContent.trim(), 'cbaa', 'caba is sorted to cbaa');
   });
 
+  test('It does not sort the array when the key is an empty string', async function(assert) {
+    this.set('array', emberArray([
+      { name: 'c' },
+      { name: 'a' },
+      { name: 'b' }
+    ]));
+
+    await render(hbs`
+      {{~#each (sort-by "" array) as |user|~}}
+        {{~user.name~}}
+      {{~/each~}}
+    `);
+
+    assert.equal(find('*').textContent.trim(), 'cab', 'cab is unsorted');
+  });
+
   test('It watches for changes', async function(assert) {
     let array = emberArray([
       { name: 'b' },