fix error happening when sqs message attributes are readonly #8473

vandonr · 2025-02-28T14:35:17Z

What Does This Do

make a copy of the message attributes before modifying them to avoid falling into errors when they are actually an immutable map.

This is the same thing as what had been done for SQS 2.0:

dd-trace-java/dd-java-agent/instrumentation/aws-java-sqs-2.0/src/main/java/datadog/trace/instrumentation/aws/v2/sqs/SqsInterceptor.java

Lines 54 to 58 in 2d7d791

    
           Map<String, MessageAttributeValue> messageAttributes = 
        
               new HashMap<>(request.messageAttributes()); 
        
           dsmPropagator.inject(ctx, messageAttributes, SETTER); 
        
           return request.toBuilder().messageAttributes(messageAttributes).build();

Motivation

customer ran into the error

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DSMS-68

pr-commenter · 2025-02-28T15:21:43Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/dsm
git_commit_date	1741016224	1741017046
git_commit_sha	`1587c49`	`8b72866`
release_version	1.47.0-SNAPSHOT~1587c4963a	1.47.0-SNAPSHOT~8b7286667a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741019522	1741019522
ci_job_id	830020573	830020573
ci_pipeline_id	57517202	57517202
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xk9phren-project-304-concurrent-1-yqjvsp8z 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xk9phren-project-304-concurrent-1-yqjvsp8z 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 69 metrics, 2 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1135261
Total [baseline] (11.47 s) : 0, 11470366
Agent [candidate] (1.148 s) : 0, 1147708
Total [candidate] (11.521 s) : 0, 11521196
section appsec
Agent [baseline] (1.271 s) : 0, 1270856
Total [baseline] (11.793 s) : 0, 11793442
Agent [candidate] (1.275 s) : 0, 1274860
Total [candidate] (11.73 s) : 0, 11730202
section iast
Agent [baseline] (1.26 s) : 0, 1260046
Total [baseline] (12.0 s) : 0, 12000084
Agent [candidate] (1.268 s) : 0, 1268020
Total [candidate] (12.0 s) : 0, 11999844
section profiling
Agent [baseline] (1.387 s) : 0, 1386978
Total [baseline] (11.958 s) : 0, 11957967
Agent [candidate] (1.383 s) : 0, 1383074
Total [candidate] (11.895 s) : 0, 11895009

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.135 s	-
Agent	appsec	1.271 s	135.595 ms (11.9%)
Agent	iast	1.26 s	124.785 ms (11.0%)
Agent	profiling	1.387 s	251.717 ms (22.2%)
Total	tracing	11.47 s	-
Total	appsec	11.793 s	323.076 ms (2.8%)
Total	iast	12.0 s	529.719 ms (4.6%)
Total	profiling	11.958 s	487.602 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.148 s	-
Agent	appsec	1.275 s	127.152 ms (11.1%)
Agent	iast	1.268 s	120.312 ms (10.5%)
Agent	profiling	1.383 s	235.365 ms (20.5%)
Total	tracing	11.521 s	-
Total	appsec	11.73 s	209.006 ms (1.8%)
Total	iast	12.0 s	478.648 ms (4.2%)
Total	profiling	11.895 s	373.813 ms (3.2%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.143 ms) : 0, 717143
BytebuddyAgent [candidate] (725.472 ms) : 0, 725472
GlobalTracer [baseline] (239.415 ms) : 0, 239415
GlobalTracer [candidate] (241.682 ms) : 0, 241682
AppSec [baseline] (55.472 ms) : 0, 55472
AppSec [candidate] (56.136 ms) : 0, 56136
Debugger [baseline] (95.249 ms) : 0, 95249
Debugger [candidate] (96.18 ms) : 0, 96180
Remote Config [baseline] (588.917 µs) : 0, 589
Remote Config [candidate] (593.463 µs) : 0, 593
Telemetry [baseline] (12.423 ms) : 0, 12423
Telemetry [candidate] (12.545 ms) : 0, 12545
section appsec
BytebuddyAgent [baseline] (734.149 ms) : 0, 734149
BytebuddyAgent [candidate] (735.758 ms) : 0, 735758
GlobalTracer [baseline] (236.151 ms) : 0, 236151
GlobalTracer [candidate] (236.995 ms) : 0, 236995
AppSec [baseline] (177.672 ms) : 0, 177672
AppSec [candidate] (178.643 ms) : 0, 178643
Debugger [baseline] (84.101 ms) : 0, 84101
Debugger [candidate] (84.512 ms) : 0, 84512
Remote Config [baseline] (630.644 µs) : 0, 631
Remote Config [candidate] (637.494 µs) : 0, 637
Telemetry [baseline] (12.352 ms) : 0, 12352
Telemetry [candidate] (12.408 ms) : 0, 12408
IAST [baseline] (21.622 ms) : 0, 21622
IAST [candidate] (21.842 ms) : 0, 21842
section iast
BytebuddyAgent [baseline] (837.184 ms) : 0, 837184
BytebuddyAgent [candidate] (843.047 ms) : 0, 843047
GlobalTracer [baseline] (230.709 ms) : 0, 230709
GlobalTracer [candidate] (231.264 ms) : 0, 231264
AppSec [baseline] (57.795 ms) : 0, 57795
AppSec [candidate] (58.193 ms) : 0, 58193
Debugger [baseline] (83.611 ms) : 0, 83611
Debugger [candidate] (84.54 ms) : 0, 84540
Remote Config [baseline] (515.967 µs) : 0, 516
Remote Config [candidate] (532.119 µs) : 0, 532
Telemetry [baseline] (12.211 ms) : 0, 12211
Telemetry [candidate] (12.361 ms) : 0, 12361
IAST [baseline] (22.994 ms) : 0, 22994
IAST [candidate] (22.949 ms) : 0, 22949
section profiling
ProfilingAgent [baseline] (123.997 ms) : 0, 123997
ProfilingAgent [candidate] (123.915 ms) : 0, 123915
BytebuddyAgent [baseline] (711.889 ms) : 0, 711889
BytebuddyAgent [candidate] (711.243 ms) : 0, 711243
GlobalTracer [baseline] (352.999 ms) : 0, 352999
GlobalTracer [candidate] (351.508 ms) : 0, 351508
AppSec [baseline] (55.86 ms) : 0, 55860
AppSec [candidate] (54.443 ms) : 0, 54443
Debugger [baseline] (88.434 ms) : 0, 88434
Debugger [candidate] (88.291 ms) : 0, 88291
Remote Config [baseline] (616.44 µs) : 0, 616
Remote Config [candidate] (616.914 µs) : 0, 617
Telemetry [baseline] (12.7 ms) : 0, 12700
Telemetry [candidate] (12.634 ms) : 0, 12634
Profiling [baseline] (124.018 ms) : 0, 124018
Profiling [candidate] (123.936 ms) : 0, 123936

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.133 s) : 0, 1133414
Total [baseline] (9.253 s) : 0, 9253151
Agent [candidate] (1.139 s) : 0, 1139212
Total [candidate] (9.331 s) : 0, 9331288
section iast
Agent [baseline] (1.271 s) : 0, 1271377
Total [baseline] (9.951 s) : 0, 9950815
Agent [candidate] (1.257 s) : 0, 1256739
Total [candidate] (9.873 s) : 0, 9873483
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.262 s) : 0, 1261610
Total [baseline] (9.864 s) : 0, 9863691
Agent [candidate] (1.26 s) : 0, 1260347
Total [candidate] (9.89 s) : 0, 9889611
section iast_TELEMETRY_OFF
Agent [baseline] (1.272 s) : 0, 1271737
Total [baseline] (9.918 s) : 0, 9917819
Agent [candidate] (1.257 s) : 0, 1256532
Total [candidate] (9.924 s) : 0, 9923528

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.133 s	-
Agent	iast	1.271 s	137.963 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.262 s	128.196 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.272 s	138.323 ms (12.2%)
Total	tracing	9.253 s	-
Total	iast	9.951 s	697.663 ms (7.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.864 s	610.54 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.918 s	664.668 ms (7.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.139 s	-
Agent	iast	1.257 s	117.527 ms (10.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.26 s	121.135 ms (10.6%)
Agent	iast_TELEMETRY_OFF	1.257 s	117.319 ms (10.3%)
Total	tracing	9.331 s	-
Total	iast	9.873 s	542.195 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.89 s	558.322 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.924 s	592.24 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.117 ms) : 0, 716117
BytebuddyAgent [candidate] (719.849 ms) : 0, 719849
GlobalTracer [baseline] (239.046 ms) : 0, 239046
GlobalTracer [candidate] (240.34 ms) : 0, 240340
AppSec [baseline] (55.612 ms) : 0, 55612
AppSec [candidate] (55.881 ms) : 0, 55881
Debugger [baseline] (94.64 ms) : 0, 94640
Debugger [candidate] (95.048 ms) : 0, 95048
Remote Config [baseline] (579.966 µs) : 0, 580
Remote Config [candidate] (582.113 µs) : 0, 582
Telemetry [baseline] (12.504 ms) : 0, 12504
Telemetry [candidate] (12.446 ms) : 0, 12446
section iast
BytebuddyAgent [baseline] (848.128 ms) : 0, 848128
BytebuddyAgent [candidate] (835.458 ms) : 0, 835458
GlobalTracer [baseline] (231.649 ms) : 0, 231649
GlobalTracer [candidate] (229.736 ms) : 0, 229736
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.747 ms) : 0, 22747
AppSec [baseline] (57.18 ms) : 0, 57180
AppSec [candidate] (57.417 ms) : 0, 57417
Debugger [baseline] (83.7 ms) : 0, 83700
Debugger [candidate] (83.636 ms) : 0, 83636
Remote Config [baseline] (526.767 µs) : 0, 527
Remote Config [candidate] (521.913 µs) : 0, 522
Telemetry [baseline] (12.167 ms) : 0, 12167
Telemetry [candidate] (12.223 ms) : 0, 12223
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.914 ms) : 0, 838914
BytebuddyAgent [candidate] (837.689 ms) : 0, 837689
GlobalTracer [baseline] (231.106 ms) : 0, 231106
GlobalTracer [candidate] (230.745 ms) : 0, 230745
IAST [baseline] (22.956 ms) : 0, 22956
IAST [candidate] (22.856 ms) : 0, 22856
AppSec [baseline] (57.114 ms) : 0, 57114
AppSec [candidate] (57.598 ms) : 0, 57598
Debugger [baseline] (83.689 ms) : 0, 83689
Debugger [candidate] (83.703 ms) : 0, 83703
Remote Config [baseline] (529.245 µs) : 0, 529
Remote Config [candidate] (526.361 µs) : 0, 526
Telemetry [baseline] (12.319 ms) : 0, 12319
Telemetry [candidate] (12.218 ms) : 0, 12218
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (846.175 ms) : 0, 846175
BytebuddyAgent [candidate] (834.652 ms) : 0, 834652
GlobalTracer [baseline] (232.396 ms) : 0, 232396
GlobalTracer [candidate] (230.589 ms) : 0, 230589
IAST [baseline] (23.62 ms) : 0, 23620
IAST [candidate] (22.508 ms) : 0, 22508
AppSec [baseline] (57.073 ms) : 0, 57073
AppSec [candidate] (57.464 ms) : 0, 57464
Debugger [baseline] (84.467 ms) : 0, 84467
Debugger [candidate] (83.729 ms) : 0, 83729
Remote Config [baseline] (534.42 µs) : 0, 534
Remote Config [candidate] (511.015 µs) : 0, 511
Telemetry [baseline] (12.208 ms) : 0, 12208
Telemetry [candidate] (12.095 ms) : 0, 12095

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-03T15:59:43	2025-03-03T16:07:40
git_branch	master	vandonr/dsm
git_commit_date	1741016224	1741017046
git_commit_sha	`1587c49`	`8b72866`
release_version	1.47.0-SNAPSHOT~1587c4963a	1.47.0-SNAPSHOT~8b7286667a
start_time	2025-03-03T15:59:29	2025-03-03T16:07:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741018467	1741018467
ci_job_id	830020575	830020575
ci_pipeline_id	57517202	57517202
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qzj9yjbu-project-304-concurrent-0-mk00nc1i 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qzj9yjbu-project-304-concurrent-0-mk00nc1i 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.321 µs) : 363, 403
.   : milestone, 383,
iast (516.814 µs) : 495, 539
.   : milestone, 517,
iast_FULL (740.051 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (570.549 µs) : 548, 593
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (512.768 µs) : 491, 535
.   : milestone, 513,
iast_INACTIVE (466.897 µs) : 445, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (500.596 µs) : 479, 522
.   : milestone, 501,
tracing (460.906 µs) : 440, 482
.   : milestone, 461,
section candidate
no_agent (382.908 µs) : 363, 402
.   : milestone, 383,
iast (516.754 µs) : 495, 539
.   : milestone, 517,
iast_FULL (734.79 µs) : 712, 757
.   : milestone, 735,
iast_GLOBAL (576.976 µs) : 553, 600
.   : milestone, 577,
iast_HARDCODED_SECRET_DISABLED (511.64 µs) : 490, 533
.   : milestone, 512,
iast_INACTIVE (468.811 µs) : 447, 490
.   : milestone, 469,
iast_TELEMETRY_OFF (498.857 µs) : 477, 521
.   : milestone, 499,
tracing (468.221 µs) : 446, 490
.   : milestone, 468,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.321 µs [363.319 µs, 403.324 µs]	-
iast	516.814 µs [495.056 µs, 538.571 µs]	133.493 µs (34.8%)
iast_FULL	740.051 µs [718.036 µs, 762.067 µs]	356.73 µs (93.1%)
iast_GLOBAL	570.549 µs [548.233 µs, 592.864 µs]	187.227 µs (48.8%)
iast_HARDCODED_SECRET_DISABLED	512.768 µs [490.863 µs, 534.673 µs]	129.447 µs (33.8%)
iast_INACTIVE	466.897 µs [445.353 µs, 488.442 µs]	83.576 µs (21.8%)
iast_TELEMETRY_OFF	500.596 µs [478.788 µs, 522.405 µs]	117.275 µs (30.6%)
tracing	460.906 µs [439.891 µs, 481.922 µs]	77.585 µs (20.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.908 µs [363.37 µs, 402.445 µs]	-
iast	516.754 µs [494.981 µs, 538.526 µs]	133.846 µs (35.0%)
iast_FULL	734.79 µs [712.487 µs, 757.093 µs]	351.882 µs (91.9%)
iast_GLOBAL	576.976 µs [553.487 µs, 600.466 µs]	194.069 µs (50.7%)
iast_HARDCODED_SECRET_DISABLED	511.64 µs [490.006 µs, 533.273 µs]	128.732 µs (33.6%)
iast_INACTIVE	468.811 µs [447.376 µs, 490.246 µs]	85.903 µs (22.4%)
iast_TELEMETRY_OFF	498.857 µs [477.18 µs, 520.534 µs]	115.949 µs (30.3%)
tracing	468.221 µs [446.244 µs, 490.199 µs]	85.314 µs (22.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1390
.   : milestone, 1370,
appsec (1.728 ms) : 1703, 1752
.   : milestone, 1728,
appsec_no_iast (1.734 ms) : 1710, 1758
.   : milestone, 1734,
code_origins (1.673 ms) : 1639, 1707
.   : milestone, 1673,
iast (1.528 ms) : 1504, 1552
.   : milestone, 1528,
profiling (1.54 ms) : 1514, 1567
.   : milestone, 1540,
tracing (1.491 ms) : 1464, 1518
.   : milestone, 1491,
section candidate
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.728 ms) : 1704, 1752
.   : milestone, 1728,
appsec_no_iast (1.715 ms) : 1691, 1740
.   : milestone, 1715,
code_origins (1.698 ms) : 1664, 1732
.   : milestone, 1698,
iast (1.508 ms) : 1484, 1533
.   : milestone, 1508,
profiling (1.51 ms) : 1485, 1534
.   : milestone, 1510,
tracing (1.5 ms) : 1476, 1525
.   : milestone, 1500,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.37 ms [1.351 ms, 1.39 ms]	-
appsec	1.728 ms [1.703 ms, 1.752 ms]	357.083 µs (26.1%)
appsec_no_iast	1.734 ms [1.71 ms, 1.758 ms]	363.51 µs (26.5%)
code_origins	1.673 ms [1.639 ms, 1.707 ms]	302.758 µs (22.1%)
iast	1.528 ms [1.504 ms, 1.552 ms]	157.556 µs (11.5%)
profiling	1.54 ms [1.514 ms, 1.567 ms]	169.963 µs (12.4%)
tracing	1.491 ms [1.464 ms, 1.518 ms]	120.684 µs (8.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.728 ms [1.704 ms, 1.752 ms]	369.771 µs (27.2%)
appsec_no_iast	1.715 ms [1.691 ms, 1.74 ms]	357.131 µs (26.3%)
code_origins	1.698 ms [1.664 ms, 1.732 ms]	339.87 µs (25.0%)
iast	1.508 ms [1.484 ms, 1.533 ms]	149.891 µs (11.0%)
profiling	1.51 ms [1.485 ms, 1.534 ms]	151.358 µs (11.1%)
tracing	1.5 ms [1.476 ms, 1.525 ms]	142.117 µs (10.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/dsm
git_commit_date	1741016224	1741017046
git_commit_sha	`1587c49`	`8b72866`
release_version	1.47.0-SNAPSHOT~1587c4963a	1.47.0-SNAPSHOT~8b7286667a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1741019029	1741019029
ci_job_id	830020577	830020577
ci_pipeline_id	57517202	57517202
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-bniqe5xm-project-304-concurrent-1-l1l65p7q 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-bniqe5xm-project-304-concurrent-1-l1l65p7q 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.345 s) : 15345000, 15345000
.   : milestone, 15345000,
appsec (14.779 s) : 14779000, 14779000
.   : milestone, 14779000,
iast (18.65 s) : 18650000, 18650000
.   : milestone, 18650000,
iast_GLOBAL (17.913 s) : 17913000, 17913000
.   : milestone, 17913000,
profiling (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
tracing (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
section candidate
no_agent (15.245 s) : 15245000, 15245000
.   : milestone, 15245000,
appsec (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
iast (18.905 s) : 18905000, 18905000
.   : milestone, 18905000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
.   : milestone, 17872000,
profiling (15.223 s) : 15223000, 15223000
.   : milestone, 15223000,
tracing (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.345 s [15.345 s, 15.345 s]	-
appsec	14.779 s [14.779 s, 14.779 s]	-566.0 ms (-3.7%)
iast	18.65 s [18.65 s, 18.65 s]	3.305 s (21.5%)
iast_GLOBAL	17.913 s [17.913 s, 17.913 s]	2.568 s (16.7%)
profiling	14.981 s [14.981 s, 14.981 s]	-364.0 ms (-2.4%)
tracing	14.917 s [14.917 s, 14.917 s]	-428.0 ms (-2.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.245 s [15.245 s, 15.245 s]	-
appsec	15.023 s [15.023 s, 15.023 s]	-222.0 ms (-1.5%)
iast	18.905 s [18.905 s, 18.905 s]	3.66 s (24.0%)
iast_GLOBAL	17.872 s [17.872 s, 17.872 s]	2.627 s (17.2%)
profiling	15.223 s [15.223 s, 15.223 s]	-22.0 ms (-0.1%)
tracing	15.09 s [15.09 s, 15.09 s]	-155.0 ms (-1.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~8b7286667a, baseline=1.47.0-SNAPSHOT~1587c4963a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.346 ms) : 2302, 2390
.   : milestone, 2346,
iast (2.125 ms) : 2070, 2181
.   : milestone, 2125,
iast_GLOBAL (2.162 ms) : 2106, 2218
.   : milestone, 2162,
profiling (1.976 ms) : 1932, 2020
.   : milestone, 1976,
tracing (1.959 ms) : 1916, 2002
.   : milestone, 1959,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.341 ms) : 2298, 2385
.   : milestone, 2341,
iast (2.119 ms) : 2063, 2174
.   : milestone, 2119,
iast_GLOBAL (2.166 ms) : 2111, 2222
.   : milestone, 2166,
profiling (1.983 ms) : 1938, 2028
.   : milestone, 1983,
tracing (1.955 ms) : 1913, 1998
.   : milestone, 1955,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.346 ms [2.302 ms, 2.39 ms]	872.904 µs (59.2%)
iast	2.125 ms [2.07 ms, 2.181 ms]	652.034 µs (44.3%)
iast_GLOBAL	2.162 ms [2.106 ms, 2.218 ms]	688.881 µs (46.8%)
profiling	1.976 ms [1.932 ms, 2.02 ms]	502.272 µs (34.1%)
tracing	1.959 ms [1.916 ms, 2.002 ms]	485.532 µs (33.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.341 ms [2.298 ms, 2.385 ms]	865.148 µs (58.6%)
iast	2.119 ms [2.063 ms, 2.174 ms]	642.949 µs (43.6%)
iast_GLOBAL	2.166 ms [2.111 ms, 2.222 ms]	690.393 µs (46.8%)
profiling	1.983 ms [1.938 ms, 2.028 ms]	506.873 µs (34.3%)
tracing	1.955 ms [1.913 ms, 1.998 ms]	479.571 µs (32.5%)

johannbotha

Thanks for the fix @vandonr.

Can we add a unit test that reproduces the Immutable map error that broke the customer's env?

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

fix error happening when sqs message attributes are readonly

151305b

vandonr added type: bug Bug report and fix inst: aws sdk AWS SDK instrumentation comp: data streams Data Streams Monitoring labels Feb 28, 2025

vandonr requested a review from a team as a code owner February 28, 2025 14:35

vandonr requested a review from roisinlh February 28, 2025 14:36

johannbotha reviewed Feb 28, 2025

View reviewed changes

vandonr added 5 commits March 3, 2025 15:10

add test

63627c2

same for batch requests

3f9489a

same for receive message requests

24a09e0

Merge remote-tracking branch 'origin/master' into vandonr/dsm

09eec49

fix test assertion

8b72866

roisinlh approved these changes Mar 3, 2025

View reviewed changes

vandonr merged commit ebb0e55 into master Mar 3, 2025
209 checks passed

vandonr deleted the vandonr/dsm branch March 3, 2025 19:12

github-actions bot added this to the 1.47.0 milestone Mar 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix error happening when sqs message attributes are readonly #8473

fix error happening when sqs message attributes are readonly #8473

Uh oh!

vandonr commented Feb 28, 2025 •

edited by atlassian bot

Loading

Uh oh!

pr-commenter bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

johannbotha left a comment

Uh oh!

Uh oh!

Uh oh!

	Map<String, MessageAttributeValue> messageAttributes =
	new HashMap<>(request.messageAttributes());
	dsmPropagator.inject(ctx, messageAttributes, SETTER);

	return request.toBuilder().messageAttributes(messageAttributes).build();

fix error happening when sqs message attributes are readonly #8473

fix error happening when sqs message attributes are readonly #8473

Uh oh!

Conversation

vandonr commented Feb 28, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

johannbotha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vandonr commented Feb 28, 2025 •

edited by atlassian bot

Loading

pr-commenter bot commented Feb 28, 2025 •

edited

Loading