Actually use CleanupTask in TempLocationManager #8420

mcculls · 2025-02-18T22:35:42Z

Motivation

This task was never scheduled or executed, but its countdown-latch was waited on during shutdown.

This resulted in the following log message each time a process was launched with profiling enabled:

[dd.trace 2025-02-18 15:07:21:489 +0000] [Temp Location Manager Cleanup] INFO com.datadog.profiling.controller.TempLocationManager - Cleanup task timed out. /var/folders/6l/65lfwqj14ps6w4gt7495gly80000gq/T/ddprof/pid_4866 temp directory might not have been cleaned up properly

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

This task was never scheduled or executed, but its countdown-latch was waited on during shutdown. This resulted in the following log message each time a process was launched with profiling enabled: [dd.trace 2025-02-18 15:07:21:489 +0000] [Temp Location Manager Cleanup] INFO com.datadog.profiling.controller.TempLocationManager - Cleanup task timed out. /var/folders/6l/65lfwqj14ps6w4gt7495gly80000gq/T/ddprof/pid_4866 temp directory might not have been cleaned up properly

pr-commenter · 2025-02-18T23:10:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/avoid-cleanup-task-log-spam
git_commit_date	1739916594	1739918005
git_commit_sha	`17f4653`	`a49cb73`
release_version	1.47.0-SNAPSHOT~17f4653dc5	1.47.0-SNAPSHOT~a49cb73df7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739920411	1739920411
ci_job_id	813108775	813108775
ci_pipeline_id	56227210	56227210
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xzwbs5cp-project-304-concurrent-0-4zo45qtd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xzwbs5cp-project-304-concurrent-0-4zo45qtd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042426
Total [baseline] (10.432 s) : 0, 10432263
Agent [candidate] (1.041 s) : 0, 1041156
Total [candidate] (10.59 s) : 0, 10589888
section appsec
Agent [baseline] (1.182 s) : 0, 1181952
Total [baseline] (10.755 s) : 0, 10754964
Agent [candidate] (1.186 s) : 0, 1186144
Total [candidate] (10.784 s) : 0, 10783852
section iast
Agent [baseline] (1.17 s) : 0, 1169898
Total [baseline] (10.989 s) : 0, 10989421
Agent [candidate] (1.185 s) : 0, 1185085
Total [candidate] (10.956 s) : 0, 10955931
section profiling
Agent [baseline] (1.276 s) : 0, 1275687
Total [baseline] (10.942 s) : 0, 10942197
Agent [candidate] (1.261 s) : 0, 1261236
Total [candidate] (10.961 s) : 0, 10960509

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.182 s	139.526 ms (13.4%)
Agent	iast	1.17 s	127.472 ms (12.2%)
Agent	profiling	1.276 s	233.261 ms (22.4%)
Total	tracing	10.432 s	-
Total	appsec	10.755 s	322.701 ms (3.1%)
Total	iast	10.989 s	557.158 ms (5.3%)
Total	profiling	10.942 s	509.933 ms (4.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	appsec	1.186 s	144.988 ms (13.9%)
Agent	iast	1.185 s	143.929 ms (13.8%)
Agent	profiling	1.261 s	220.08 ms (21.1%)
Total	tracing	10.59 s	-
Total	appsec	10.784 s	193.965 ms (1.8%)
Total	iast	10.956 s	366.044 ms (3.5%)
Total	profiling	10.961 s	370.621 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.06 ms) : 0, 718060
BytebuddyAgent [candidate] (716.512 ms) : 0, 716512
GlobalTracer [baseline] (239.894 ms) : 0, 239894
GlobalTracer [candidate] (241.007 ms) : 0, 241007
AppSec [baseline] (55.624 ms) : 0, 55624
AppSec [candidate] (55.66 ms) : 0, 55660
Remote Config [baseline] (705.348 µs) : 0, 705
Remote Config [candidate] (720.143 µs) : 0, 720
Telemetry [baseline] (12.885 ms) : 0, 12885
Telemetry [candidate] (12.086 ms) : 0, 12086
section appsec
BytebuddyAgent [baseline] (734.069 ms) : 0, 734069
BytebuddyAgent [candidate] (736.454 ms) : 0, 736454
GlobalTracer [baseline] (236.234 ms) : 0, 236234
GlobalTracer [candidate] (237.607 ms) : 0, 237607
AppSec [baseline] (176.893 ms) : 0, 176893
AppSec [candidate] (177.184 ms) : 0, 177184
Remote Config [baseline] (668.758 µs) : 0, 669
Remote Config [candidate] (667.127 µs) : 0, 667
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.273 ms) : 0, 8273
IAST [baseline] (21.323 ms) : 0, 21323
IAST [candidate] (21.425 ms) : 0, 21425
section iast
BytebuddyAgent [baseline] (835.3 ms) : 0, 835300
BytebuddyAgent [candidate] (846.582 ms) : 0, 846582
GlobalTracer [baseline] (230.106 ms) : 0, 230106
GlobalTracer [candidate] (232.826 ms) : 0, 232826
AppSec [baseline] (57.252 ms) : 0, 57252
AppSec [candidate] (57.396 ms) : 0, 57396
Remote Config [baseline] (611.711 µs) : 0, 612
Remote Config [candidate] (632.672 µs) : 0, 633
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.871 ms) : 0, 8871
IAST [baseline] (22.69 ms) : 0, 22690
IAST [candidate] (23.361 ms) : 0, 23361
section profiling
BytebuddyAgent [baseline] (716.682 ms) : 0, 716682
BytebuddyAgent [candidate] (708.072 ms) : 0, 708072
GlobalTracer [baseline] (353.671 ms) : 0, 353671
GlobalTracer [candidate] (351.167 ms) : 0, 351167
AppSec [baseline] (55.752 ms) : 0, 55752
AppSec [candidate] (54.909 ms) : 0, 54909
Remote Config [baseline] (691.07 µs) : 0, 691
Remote Config [candidate] (687.291 µs) : 0, 687
Telemetry [baseline] (9.018 ms) : 0, 9018
Telemetry [candidate] (8.924 ms) : 0, 8924
ProfilingAgent [baseline] (97.034 ms) : 0, 97034
ProfilingAgent [candidate] (95.161 ms) : 0, 95161
Profiling [baseline] (97.058 ms) : 0, 97058
Profiling [candidate] (95.185 ms) : 0, 95185

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039254
Total [baseline] (8.637 s) : 0, 8636872
Agent [candidate] (1.044 s) : 0, 1044139
Total [candidate] (8.644 s) : 0, 8644146
section iast
Agent [baseline] (1.171 s) : 0, 1171424
Total [baseline] (9.255 s) : 0, 9254514
Agent [candidate] (1.171 s) : 0, 1171427
Total [candidate] (9.249 s) : 0, 9248943
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174715
Total [baseline] (9.21 s) : 0, 9210173
Agent [candidate] (1.177 s) : 0, 1176880
Total [candidate] (9.239 s) : 0, 9238581
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165781
Total [baseline] (9.246 s) : 0, 9246468
Agent [candidate] (1.176 s) : 0, 1175988
Total [candidate] (9.256 s) : 0, 9255730

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	iast	1.171 s	132.17 ms (12.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	135.461 ms (13.0%)
Agent	iast_TELEMETRY_OFF	1.166 s	126.527 ms (12.2%)
Total	tracing	8.637 s	-
Total	iast	9.255 s	617.642 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.21 s	573.302 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.246 s	609.596 ms (7.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.171 s	127.288 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.177 s	132.741 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.176 s	131.849 ms (12.6%)
Total	tracing	8.644 s	-
Total	iast	9.249 s	604.797 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.239 s	594.435 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.256 s	611.583 ms (7.1%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.049 ms) : 0, 717049
BytebuddyAgent [candidate] (718.551 ms) : 0, 718551
GlobalTracer [baseline] (238.997 ms) : 0, 238997
GlobalTracer [candidate] (239.609 ms) : 0, 239609
AppSec [baseline] (55.306 ms) : 0, 55306
AppSec [candidate] (55.779 ms) : 0, 55779
Remote Config [baseline] (696.284 µs) : 0, 696
Remote Config [candidate] (704.636 µs) : 0, 705
Telemetry [baseline] (12.131 ms) : 0, 12131
Telemetry [candidate] (14.412 ms) : 0, 14412
section iast
BytebuddyAgent [baseline] (836.544 ms) : 0, 836544
BytebuddyAgent [candidate] (836.065 ms) : 0, 836065
GlobalTracer [baseline] (230.68 ms) : 0, 230680
GlobalTracer [candidate] (230.576 ms) : 0, 230576
IAST [baseline] (22.588 ms) : 0, 22588
IAST [candidate] (22.885 ms) : 0, 22885
AppSec [baseline] (57.116 ms) : 0, 57116
AppSec [candidate] (57.329 ms) : 0, 57329
Remote Config [baseline] (618.712 µs) : 0, 619
Remote Config [candidate] (612.279 µs) : 0, 612
Telemetry [baseline] (8.657 ms) : 0, 8657
Telemetry [candidate] (8.785 ms) : 0, 8785
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.676 ms) : 0, 838676
BytebuddyAgent [candidate] (840.646 ms) : 0, 840646
GlobalTracer [baseline] (230.883 ms) : 0, 230883
GlobalTracer [candidate] (231.657 ms) : 0, 231657
IAST [baseline] (22.875 ms) : 0, 22875
IAST [candidate] (22.949 ms) : 0, 22949
AppSec [baseline] (57.659 ms) : 0, 57659
AppSec [candidate] (57.114 ms) : 0, 57114
Remote Config [baseline] (612.682 µs) : 0, 613
Remote Config [candidate] (599.326 µs) : 0, 599
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.584 ms) : 0, 8584
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.784 ms) : 0, 832784
BytebuddyAgent [candidate] (839.857 ms) : 0, 839857
GlobalTracer [baseline] (229.967 ms) : 0, 229967
GlobalTracer [candidate] (231.682 ms) : 0, 231682
IAST [baseline] (27.449 ms) : 0, 27449
IAST [candidate] (24.857 ms) : 0, 24857
AppSec [baseline] (51.178 ms) : 0, 51178
AppSec [candidate] (55.144 ms) : 0, 55144
Remote Config [baseline] (616.397 µs) : 0, 616
Remote Config [candidate] (623.322 µs) : 0, 623
Telemetry [baseline] (8.519 ms) : 0, 8519
Telemetry [candidate] (8.606 ms) : 0, 8606

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-18T22:45:36	2025-02-18T22:52:42
git_branch	master	mcculls/avoid-cleanup-task-log-spam
git_commit_date	1739916594	1739918005
git_commit_sha	`17f4653`	`a49cb73`
release_version	1.47.0-SNAPSHOT~17f4653dc5	1.47.0-SNAPSHOT~a49cb73df7
start_time	2025-02-18T22:45:22	2025-02-18T22:52:28

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739919521	1739919521
ci_job_id	813108776	813108776
ci_pipeline_id	56227210	56227210
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-kpnzgrdt-project-304-concurrent-2-y9wsf6nv 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-kpnzgrdt-project-304-concurrent-2-y9wsf6nv 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.445 µs) : 361, 400
.   : milestone, 380,
iast (512.91 µs) : 491, 534
.   : milestone, 513,
iast_FULL (729.891 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (565.054 µs) : 543, 588
.   : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (526.658 µs) : 504, 550
.   : milestone, 527,
iast_INACTIVE (470.229 µs) : 449, 492
.   : milestone, 470,
iast_TELEMETRY_OFF (504.993 µs) : 482, 528
.   : milestone, 505,
tracing (459.818 µs) : 438, 481
.   : milestone, 460,
section candidate
no_agent (392.232 µs) : 369, 416
.   : milestone, 392,
iast (520.091 µs) : 498, 542
.   : milestone, 520,
iast_FULL (733.694 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (562.321 µs) : 540, 584
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (518.884 µs) : 496, 542
.   : milestone, 519,
iast_INACTIVE (471.394 µs) : 449, 493
.   : milestone, 471,
iast_TELEMETRY_OFF (505.235 µs) : 484, 527
.   : milestone, 505,
tracing (463.541 µs) : 442, 485
.   : milestone, 464,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.445 µs [360.824 µs, 400.066 µs]	-
iast	512.91 µs [491.457 µs, 534.364 µs]	132.465 µs (34.8%)
iast_FULL	729.891 µs [707.871 µs, 751.912 µs]	349.446 µs (91.9%)
iast_GLOBAL	565.054 µs [542.565 µs, 587.542 µs]	184.609 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED	526.658 µs [503.626 µs, 549.69 µs]	146.213 µs (38.4%)
iast_INACTIVE	470.229 µs [448.589 µs, 491.868 µs]	89.784 µs (23.6%)
iast_TELEMETRY_OFF	504.993 µs [481.839 µs, 528.148 µs]	124.548 µs (32.7%)
tracing	459.818 µs [438.454 µs, 481.183 µs]	79.373 µs (20.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	392.232 µs [368.555 µs, 415.908 µs]	-
iast	520.091 µs [498.383 µs, 541.799 µs]	127.86 µs (32.6%)
iast_FULL	733.694 µs [711.793 µs, 755.595 µs]	341.462 µs (87.1%)
iast_GLOBAL	562.321 µs [540.38 µs, 584.262 µs]	170.09 µs (43.4%)
iast_HARDCODED_SECRET_DISABLED	518.884 µs [496.204 µs, 541.565 µs]	126.653 µs (32.3%)
iast_INACTIVE	471.394 µs [449.333 µs, 493.454 µs]	79.162 µs (20.2%)
iast_TELEMETRY_OFF	505.235 µs [483.584 µs, 526.887 µs]	113.004 µs (28.8%)
tracing	463.541 µs [442.289 µs, 484.793 µs]	71.309 µs (18.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1382
.   : milestone, 1362,
appsec (1.766 ms) : 1743, 1790
.   : milestone, 1766,
appsec_no_iast (1.745 ms) : 1720, 1770
.   : milestone, 1745,
iast (1.506 ms) : 1482, 1529
.   : milestone, 1506,
profiling (1.49 ms) : 1466, 1513
.   : milestone, 1490,
tracing (1.519 ms) : 1494, 1543
.   : milestone, 1519,
section candidate
no_agent (1.362 ms) : 1342, 1382
.   : milestone, 1362,
appsec (1.748 ms) : 1724, 1771
.   : milestone, 1748,
appsec_no_iast (1.759 ms) : 1736, 1782
.   : milestone, 1759,
iast (1.504 ms) : 1481, 1528
.   : milestone, 1504,
profiling (1.537 ms) : 1512, 1562
.   : milestone, 1537,
tracing (1.506 ms) : 1481, 1531
.   : milestone, 1506,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.362 ms [1.342 ms, 1.382 ms]	-
appsec	1.766 ms [1.743 ms, 1.79 ms]	404.418 µs (29.7%)
appsec_no_iast	1.745 ms [1.72 ms, 1.77 ms]	382.668 µs (28.1%)
iast	1.506 ms [1.482 ms, 1.529 ms]	143.609 µs (10.5%)
profiling	1.49 ms [1.466 ms, 1.513 ms]	127.742 µs (9.4%)
tracing	1.519 ms [1.494 ms, 1.543 ms]	156.583 µs (11.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.362 ms [1.342 ms, 1.382 ms]	-
appsec	1.748 ms [1.724 ms, 1.771 ms]	385.453 µs (28.3%)
appsec_no_iast	1.759 ms [1.736 ms, 1.782 ms]	396.876 µs (29.1%)
iast	1.504 ms [1.481 ms, 1.528 ms]	142.364 µs (10.5%)
profiling	1.537 ms [1.512 ms, 1.562 ms]	174.646 µs (12.8%)
tracing	1.506 ms [1.481 ms, 1.531 ms]	143.867 µs (10.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/avoid-cleanup-task-log-spam
git_commit_date	1739916594	1739918005
git_commit_sha	`17f4653`	`a49cb73`
release_version	1.47.0-SNAPSHOT~17f4653dc5	1.47.0-SNAPSHOT~a49cb73df7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739920095	1739920095
ci_job_id	813108777	813108777
ci_pipeline_id	56227210	56227210
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xzwbs5cp-project-304-concurrent-1-c407uon0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xzwbs5cp-project-304-concurrent-1-c407uon0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.368 ms) : 2325, 2411
.   : milestone, 2368,
iast (2.114 ms) : 2059, 2169
.   : milestone, 2114,
iast_GLOBAL (2.161 ms) : 2106, 2217
.   : milestone, 2161,
profiling (1.985 ms) : 1941, 2030
.   : milestone, 1985,
tracing (1.947 ms) : 1905, 1989
.   : milestone, 1947,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.364 ms) : 2320, 2407
.   : milestone, 2364,
iast (2.124 ms) : 2069, 2179
.   : milestone, 2124,
iast_GLOBAL (2.163 ms) : 2108, 2218
.   : milestone, 2163,
profiling (1.995 ms) : 1949, 2041
.   : milestone, 1995,
tracing (1.952 ms) : 1910, 1995
.   : milestone, 1952,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.368 ms [2.325 ms, 2.411 ms]	896.64 µs (60.9%)
iast	2.114 ms [2.059 ms, 2.169 ms]	642.782 µs (43.7%)
iast_GLOBAL	2.161 ms [2.106 ms, 2.217 ms]	690.042 µs (46.9%)
profiling	1.985 ms [1.941 ms, 2.03 ms]	513.699 µs (34.9%)
tracing	1.947 ms [1.905 ms, 1.989 ms]	475.411 µs (32.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.364 ms [2.32 ms, 2.407 ms]	891.11 µs (60.5%)
iast	2.124 ms [2.069 ms, 2.179 ms]	651.269 µs (44.2%)
iast_GLOBAL	2.163 ms [2.108 ms, 2.218 ms]	690.176 µs (46.9%)
profiling	1.995 ms [1.949 ms, 2.041 ms]	522.295 µs (35.5%)
tracing	1.952 ms [1.91 ms, 1.995 ms]	479.764 µs (32.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a49cb73df7, baseline=1.47.0-SNAPSHOT~17f4653dc5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
appsec (14.758 s) : 14758000, 14758000
.   : milestone, 14758000,
iast (18.617 s) : 18617000, 18617000
.   : milestone, 18617000,
iast_GLOBAL (17.803 s) : 17803000, 17803000
.   : milestone, 17803000,
profiling (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
tracing (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
section candidate
no_agent (15.182 s) : 15182000, 15182000
.   : milestone, 15182000,
appsec (15.122 s) : 15122000, 15122000
.   : milestone, 15122000,
iast (18.872 s) : 18872000, 18872000
.   : milestone, 18872000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
.   : milestone, 18101000,
profiling (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.178 s [15.178 s, 15.178 s]	-
appsec	14.758 s [14.758 s, 14.758 s]	-420.0 ms (-2.8%)
iast	18.617 s [18.617 s, 18.617 s]	3.439 s (22.7%)
iast_GLOBAL	17.803 s [17.803 s, 17.803 s]	2.625 s (17.3%)
profiling	15.089 s [15.089 s, 15.089 s]	-89.0 ms (-0.6%)
tracing	15.076 s [15.076 s, 15.076 s]	-102.0 ms (-0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.182 s [15.182 s, 15.182 s]	-
appsec	15.122 s [15.122 s, 15.122 s]	-60.0 ms (-0.4%)
iast	18.872 s [18.872 s, 18.872 s]	3.69 s (24.3%)
iast_GLOBAL	18.101 s [18.101 s, 18.101 s]	2.919 s (19.2%)
profiling	14.957 s [14.957 s, 14.957 s]	-225.0 ms (-1.5%)
tracing	14.954 s [14.954 s, 14.954 s]	-228.0 ms (-1.5%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

mcculls added type: bug Bug report and fix comp: profiling Profiling labels Feb 18, 2025

mcculls requested a review from a team as a code owner February 18, 2025 22:35

mcculls requested a review from jbachorik February 18, 2025 22:35

jbachorik approved these changes Feb 19, 2025

View reviewed changes

mcculls merged commit 0dafd10 into master Feb 19, 2025
203 of 204 checks passed

mcculls deleted the mcculls/avoid-cleanup-task-log-spam branch February 19, 2025 10:16

github-actions bot added this to the 1.47.0 milestone Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Actually use CleanupTask in TempLocationManager #8420

Actually use CleanupTask in TempLocationManager #8420

mcculls commented Feb 18, 2025

Uh oh!

pr-commenter bot commented Feb 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Actually use CleanupTask in TempLocationManager #8420

Actually use CleanupTask in TempLocationManager #8420

Conversation

mcculls commented Feb 18, 2025

Motivation

Contributor Checklist

Uh oh!

pr-commenter bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

pr-commenter bot commented Feb 18, 2025 •

edited

Loading