Skip to content

Fixed edge case in engagement score normalisation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fixed edge case in engagement score normalisation #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions .../serverless/microservices/python/crowd-members-score/crowd/members_score/members_score.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ def __init__(self, tenant_id, repository=False, test=False, send=True):
self.repository = repository

self.fetch_scores()
# print([
# member.id for member in self.repository.find_all(Tenant, query={})
# ])

print(self.tenants.fetchall())
self.team_members = [
member.id for member in self.repository.find_all(CommunityMember, query={"crowdInfo.team": True})
]
Expand Down Expand Up @@ -76,11 +71,7 @@ def fetch_scores(self):
group by "communityMemberId", date("timestamp")) T on T."cm_id"=FullDates."communityMemberId" and T."timestamp" = FullDates.MyJoinDate\
group by FullDates."communityMemberId", FullDates.MyJoinDate order by FullDates.MyJoinDate asc\
) Daily group by "communityMemberId", extract(month from MyJoinDate), extract(year from MyJoinDate)'
)

self.tenants = con.execute(
'select count(*), "tenantId" from "communityMembers" cm group by "tenantId" order by count(*) ASC'
)
).fetchall()

def _calculate_months(self, date):
"""
Expand Down Expand Up @@ -140,9 +131,7 @@ def _member_scores_(self, members):
to the score of the member.
"""

id = self.repository.tenant_id

mean_scores = self.mean_scores.fetchall()
mean_scores = self.mean_scores

scores = {}
for i, row in enumerate(mean_scores):
Expand Down Expand Up @@ -218,6 +207,10 @@ def main(self):
self.scores = self._member_scores_(members)
logger.info("Done")

# Take care of case where tenant doesn't have activities
if len(self.scores) == 0:
return {}

logger.info("Normalising scores...")
scores_to_update = self.normalise(self.scores)
logger.info("Done")
Expand Down