Skip to content

Conversation

CallmeMehdi
Copy link
Contributor

@CallmeMehdi CallmeMehdi commented Aug 25, 2022

Changes proposed ✍️

  • Added handling of edge case for engagement normalization when the tenant doesn't have any activities
  • Screenshots (front-end changes only)

      - ...  
    

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanreyero
Copy link
Contributor

Can we test in staging before merging?

@joanreyero joanreyero changed the title Hotfix/Added-edge-case-engagement-normalization Fixed edge case in engagement score normalisation Aug 26, 2022
@CallmeMehdi CallmeMehdi merged commit 3882dd1 into main Aug 29, 2022
@CallmeMehdi CallmeMehdi deleted the bugfix/engagement_normalization_fix branch August 29, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants