Cosmos: Fix #2824 by forcing 'enable_content_response_on_write' on for read item #2894
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
requested review from
Pilchie,
kirankumarkolli,
tvaron3,
FabianMeiswinkel,
kundadebdatta,
nehrao1,
kushagraThapar,
heaths,
RickWinter,
ronniegeraghty and
LarryOsterman
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Cosmos Database issue #2824 by ensuring read operations return content, and addresses test failures after HTTP behavior changes in #2834. The fix prevents read operations from returning empty responses when the enable_content_response_on_write flag is disabled.
Key changes:
- Added error handling for non-2xx HTTP status codes in the Cosmos pipeline
- Force
enable_content_response_on_writetotruefor read item operations - Updated test code to properly handle HTTP error responses
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/typespec/typespec_client_core/src/http/response.rs | Added success() method to validate HTTP status codes and convert errors |
| sdk/cosmos/azure_data_cosmos/src/pipeline/mod.rs | Implemented error handling for non-2xx responses in pipeline operations |
| sdk/cosmos/azure_data_cosmos/src/clients/container_client.rs | Fixed read_item to force content response flag to true |
| sdk/cosmos/azure_data_cosmos/tests/framework/test_data/mod.rs | Updated test to use new error handling pattern |
| sdk/cosmos/azure_data_cosmos/tests/framework/test_account.rs | Updated test to use new error handling pattern |
heaths
approved these changes
Aug 8, 2025
Pilchie
approved these changes
Aug 11, 2025
analogrelay
force-pushed
the
ashleyst/fix-2824
branch
from
3691354 to
6fb7837
Compare
3 tasks
|
/azp run rust - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
heaths
approved these changes
Aug 14, 2025
analogrelay
force-pushed
the
ashleyst/fix-2824
branch
from
6fb7837 to
7906642
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Pilchie
approved these changes
Sep 10, 2025
heaths
approved these changes
Sep 11, 2025
heaths
approved these changes
Sep 16, 2025
analogrelay
force-pushed
the
ashleyst/fix-2824
branch
from
7aa4e71 to
c6a2367
Compare
heaths
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes in one, but I think it's reasonable:
Ok. We now convert non-2xx status codes to errors in the Cosmos Pipelineenable_content_response_on_writeflag totruewhen reading an item.I needed to do 1 in order for the tests to properly start failing on errors after #2834, and then I went in to fix the bug. Otherwise a pretty straightforward change :)