updates for check_success

Author: analogrelay

sdk/cosmos/azure_data_cosmos/src/pipeline/mod.rs

@@ -13,15 +13,6 @@ use azure_core::http::{
     response::Response,
     BufResponse, ClientOptions, Context, Method,
 };
-use azure_core::{
-    error::HttpError,
-    http::{
-        pager::PagerState,
-        request::{options::ContentType, Request},
-        response::Response,
-        ClientOptions, Context, Method, RawResponse,
-    },
-};
 use futures::TryStreamExt;
 use serde::de::DeserializeOwned;
 use url::Url;
@@ -75,7 +66,9 @@ impl CosmosPipeline {
         resource_link: ResourceLink,
     ) -> azure_core::Result<BufResponse> {
         let ctx = ctx.with_value(resource_link);
-        self.pipeline.send(&ctx, request).await?.success().await
+        let r = self.pipeline.send(&ctx, request).await?;
+        let r = azure_core::http::check_success(r).await?;
+        Ok(r)
     }
 
     pub async fn send<T>(
@@ -116,7 +109,8 @@ impl CosmosPipeline {
                     req.insert_header(constants::CONTINUATION, continuation);
                 }
 
-                let resp = pipeline.send(&ctx, &mut req).await?.success().await?;
+                let resp = pipeline.send(&ctx, &mut req).await?;
+                let resp = azure_core::http::check_success(resp).await?;
                 let page = FeedPage::<T>::from_response(resp).await?;
 
                 Ok(page.into())
@@ -202,39 +196,3 @@ pub(crate) fn create_base_query_request(url: Url, query: &Query) -> azure_core::
     request.set_json(query)?;
     Ok(request)
 }
-
-trait ResponseExt {
-    async fn success(self) -> azure_core::Result<Self>
-    where
-        Self: Sized;
-}
-
-impl<T, F> ResponseExt for Response<T, F> {
-    async fn success(self) -> azure_core::Result<Self> {
-        if self.status().is_success() {
-            Ok(self)
-        } else {
-            RawResponse::from(self).success().await.map(Into::into)
-        }
-    }
-}
-
-impl ResponseExt for RawResponse {
-    async fn success(self) -> azure_core::Result<Self> {
-        if self.status().is_success() {
-            Ok(self)
-        } else {
-            let http_error = HttpError::new(self, Some(constants::SUB_STATUS)).await;
-            let status = http_error.status();
-            let error_kind = azure_core::error::ErrorKind::http_response(
-                status,
-                http_error.error_code().map(ToOwned::to_owned),
-            );
-            Err(azure_core::Error::full(
-                error_kind,
-                http_error,
-                format!("Request failed with status code: {}", status),
-            ))
-        }
-    }
-}