Skip to content

Conversation

kamboj-prjwl
Copy link
Member





This reverts commit ca6e724.






Removed delay-related tests for RecordedTestBase.

  • Remove async processing test from TestUtilitiesIntegrationTests

Removed the test for async processing in MockTransport.

  • Specified build command in the configuration for .NET again

This reverts commit fd4b2d1.

  • Prepare for the release (Prepare for the release #52715)

  • Sync eng/common directory with azure-sdk-tools for PR 11868 (Sync eng/common directory with azure-sdk-tools for PR 11868 #52707)

  • added instructions for sdk local workflow

  • fix case

  • Added missing comma

  • Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

  • Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

  • Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

  • Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

  • Replace 'tspconfigPath' by the literal file name

  • Added routing step to choose workflow

  • Added goal and action to some steps properly

  • Specified mcp tool name explicitly

  • Added back step to choose sdk generation approach

  • Specified the mcp tool names explicitly

  • Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md



  • update

  • update


Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

* [Storage][DataMovement] Fix some failing live tests (#52551)

* .NET SDK Network Release Version 2024-10-01

* build: bump MTG version (#52562)

* build: bump MTG version

* bump to official version

* Prepare HttpPipelineHelper to onbord customer sdk stats. (#52565)

* Initial release for Azure.ResourceManager.Resources.Bicep (#50751)

* Release ComputeSchedule .NET sdk for api-version 2025-05-01 (#52284)

* Remove internal setter from collection-type property (#52554)

* Remove internal setter from collection-type property

* typo

* set flatten property

* fix

* Update TypeSpec emitter version to prerelease 1.0.0-alpha.20250911.1 (#52573)

* Regenerate repository SDK with TypeSpec build 20250911.1

* Update SDK code re_wo_4

* Update SDK code lo_re_3

* Increment package version after release of Azure.ResourceManager.ComputeSchedule (#52575)

* Remove setter for safeflatten collection-type property and handle nullability check (#52574)

* Remove setter for safeflatten collection-type property and handle nullability check

* cleanup

* cleanup

* add codeowner (#52570)

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250911.1 (#52582)

Co-authored-by: Ubuntu <cloudtest@cd62265fc00000I.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>

* [Storage] [DataMovement] Merge hotfix branch DMLib into main (#52586)

* [Storage][DataMovement[ Prepare hotfix release for 12.2.2 (#52560)

* Increment version for storage releases (#52567)

* Increment package version after release of Azure.Storage.DataMovement

* Increment package version after release of Azure.Storage.DataMovement.Blobs

* Increment package version after release of Azure.Storage.DataMovement.Files.Shares

---------

Co-authored-by: Jacob Lauzon <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>

* Add custom instructions to fetch TypeSpec docs (#52588)

Co-authored-by: Christopher Radek <[email protected]>

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250911.3 (#52590)

Co-authored-by: Ubuntu <cloudtest@88659a30c00000J.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>

* Make Prepare-Release.ps1 executable (#52592)

Co-authored-by: Heath Stewart <[email protected]>

* Synapse release Sep 2025 (#52389)

* Synapse Artifacts: update models and serialization for new release (Sep)

* Update CHANGELOG.md to include new parameters and breaking changes for various models

* remove empty section

* Add setter for collection-type property during safe flatten to avoid massive breaking changes (#52596)

* Update TypeSpec emitter version to prerelease 1.0.0-alpha.20250911.3 (#52599)

* Regenerate repository SDK with TypeSpec build 20250911.3

* Update SDK code re_wo_4

* Increment package version after release of Azure.Analytics.Synapse.Artifacts (#52597)

* Release Azure.ResourceManager.ComputeSchedule 1.2.0-beta.1 (#52600)

* Increment package version after release of Azure.ResourceManager.ComputeSchedule (#52604)

* Update documentation for AuthorizationCodeCredential (#52605)

* scope resource support. (#52598)

* scope resource support.

* Regenerate repository SDK with TypeSpec build 20250911.2 (#52576)

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250912.1 (#52609)

Co-authored-by: Ubuntu <cloudtest@e0ee3965c000007.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>

* [Microsoft.ClientModel.TestFramework] Update test-proxy tool logic (#52589)

* update test proxy tool location

* Update sdk/core/Microsoft.ClientModel.TestFramework/src/RecordedTests/TestProxy/TestProxyProcess.cs

Co-authored-by: Copilot <[email protected]>

* fix

---------

Co-authored-by: Copilot <[email protected]>

* feat: bump keyvault admin spec (#52581)

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250912.2 (#52610)

Co-authored-by: Ubuntu <cloudtest@632c522dc000005.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>

* Fix tenantId selection in MSAL (#52613)

* Add comprehensive samples for missing Azure.OpenAI APIs (#52137)

* Update TypeSpec emitter version to prerelease 1.0.0-alpha.20250912.2 (#52614)

* Regenerate repository SDK with TypeSpec build 20250912.2

* Update SDK code ag_co_0

* regen

---------

Co-authored-by: jolov <[email protected]>

* Optimize the Telemetry test for C# (#52615)

* [Microsoft.ContainerInstance] Rectify latest preview API version (#52538)

* Support "tuple resource" in new management generator (#52537)

* change resource scope detection logic.

* fix grammar error in commnet line.

* regen test project.

* add playwright.tsp.

* working in progress.

* refine.

* refine.

* refine.

* ready for review.

* refine.

* address review comments.

* address review comments.

* fix format issue.

* address review comments.

* a small fix.

* address review comments.

* Specified build command in the configuration for .NET (#52546)

* Specified build command  in the configuration

* updated the schema path

* Add Debug to list of parameters copied for SearchOptions. (#52629)

* Sync eng/common directory with azure-sdk-tools for PR 11931 (#52630)

* Update create release plan instructions and return

* Update eng/common/instructions/azsdk-tools/create-release-plan.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Return Release Plan Details

* Update eng/common/instructions/azsdk-tools/create-release-plan.instructions.md

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Add more specific rules for release plan creation

* Add Better instructions

---------

Co-authored-by: Summer Warren <[email protected]>
Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>

* Revert "Specified build command in the configuration for .NET (#52546)" (#52632)

This reverts commit ca6e724.

* Change LogProb data type (#52523)

* Change LogProb data type

* Missed file

* API Updates

* File cleanup; remove public BinaryData from more places

* Latest updates

* n progress

* Add tests

* Latest updates

* Lots of test updates and API simplification

* Snippet and API updates

* Remove run settings

* Don't add a readme w/ the tests

* More tests and refactoring

* Generator updates

* Improve Error Handling

* Regenerate repository SDK with TypeSpec build 20250915.1 (#52627)

* Autogenerate KeyVault API for 2025-05-01 (#52611)

Co-authored-by: Konstantin Semenov <[email protected]>

* [AutoPR Azure.ResourceManager.ComputeRecommender]-generated-from-SDK Generation - .NET-5265404 (#52258)

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Elina Liu <[email protected]>

* [AutoPR Azure.ResourceManager.DisconnectedOperations]-generated-from-SDK Generation - .NET-5341663 (#52637)

Co-authored-by: Avinash Ranjan <[email protected]>

* Update Generator Version 3.0.0-beta.20250916.1 (#52642)

Co-authored-by: azure-sdk <[email protected]>

* WorkloadOrchestration Initial SDK Release (#50571)

* Made Changes

* Made changes

* Added

* Made changes

* Added

* Added

* AZdded

* vhfrhj

* Commit

* Added

* Madec

* Recording

* Added

* Added Tests

* Added changesset

* Added Commit

* Added some changes

* Added Commit

* Added Fix

* h

* Added

* Added some changes

* Added

* made changes

* Remove siteconfiguration

* Made changes

* Added Changes

* made c

* Added change date

* Made changes suggested

* Made changes

* Made changes

* convert to generate sdk from typespec

* update

* update

* update

* update

* Added codeowner

---------

Co-authored-by: Atharva Udapure <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>

* [Storage] [DataMovement] Changelogs for 12.3.0-beta.1 Release (#52646)

* changelogs

* Added date and changelogs for DM Lib base and blobs

* Made DMLib & DMLib.Blobs chnagelogs more generic

* Removed unused sections

* Add support for @azure-typespec/http-client-csharp emitter in GenerateAndBuildLib.ps1 (#52635)

* Initial plan

* Initial analysis and test baseline for GenerateAndBuildLib.ps1 emitter support

Co-authored-by: JoshLove-msft <[email protected]>

* Add support for @azure-typespec/http-client-csharp emitter in GenerateAndBuildLib.ps1

Co-authored-by: JoshLove-msft <[email protected]>

* Remove test artifact file autorest.md

Co-authored-by: JoshLove-msft <[email protected]>

* Restore all sdk files to original state - revert sdk directory changes

Co-authored-by: JoshLove-msft <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>

* Include diagnostics when trace is enabled (#52647)

* [Microsoft.ClientModel.TestFramework] Add support for non-generic collection results to support protocol method testing (#52633)

* tweaks

* fb

* Increment version for storage releases (#52648)

* Update changelog (#52649)

* Update changelog

* Update fromat

* (playwrighttesting): Removed sorce code for both CP and DP sdk for playwrighttesting (#52601)

* Promote ACS Email SDK to stable version 2025-09-01 (#52654)

* use 2025-09-01

* disable SendSuperLongTextMessage_ShouldFail()

* Fix Message blocks serialization. (#52653)

* Fix Message blocks serialization.

* Fix

* Increment package version after release of Azure.ResourceManager.WorkloadOrchestration (#52655)

* Increment package version after release of Azure.ResourceManager.ContainerInstance (#52656)

* Prepare AOT-safe release for Azure.ResourceManager.SignalR (#52643)

* Update core JS dependencies for Azure Management Generator (#52639)

* Initial plan

* Update JS dependencies to latest versions for Azure Mgmt Generator

Co-authored-by: ArcturusZhang <[email protected]>

* Fix @flattenProperty decorator namespace to Azure.ClientGenerator.Core.Legacy

Co-authored-by: ArcturusZhang <[email protected]>

* Revert development tool dependencies to original versions

Co-authored-by: ArcturusZhang <[email protected]>

* Fix npm list --all pipeline failure by updating @types/node version

Co-authored-by: ArcturusZhang <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: ArcturusZhang <[email protected]>

* [AutoPR Azure.ResourceManager.StorageMover]-generated-from-SDK Generation - .NET-5271391 (#52296)

Co-authored-by: Arthur Ma <[email protected]>

* fix ci in computerecommender (#52659)

* Update commitId for flatten decorator legacy namespace move (#52640)

Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: azure-sdk <[email protected]>

* fix issue in populate rest operation arguments. (#52663)

* Regenerate repository SDK with TypeSpec build 20250916.1 (#52662)

Co-authored-by: azure-sdk <[email protected]>

* update (#52665)

* ci(mgmt): remove unused per-package path list from sdk/resourcemanager/ci.mgmt.yml (#52666)

* Roll back the release setup for Azure.ResourceManager.StorageMover. (#52668)

* change request path ancestor relationship detection logic. (#52669)

* change request path ancestor relationship dectection logic.

* refine.

* refine.

* Increment package version after release of Azure.AI.VoiceLive (#52657)

* Increment package version after release of Azure.ResourceManager.IotFirmwareDefense (#52660)

* [Storage][DataMovement] Fix some more flakey Live tests (#52584)

* Small changes to test Live pipeline

* updated comments

* bumped up cancellationToken time

* slight increase in delay

* bumped timeouts a little to see if this can avoid 'Operation was canceled' error

* Give more time to wait for resume to complete

* small changes

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250917.1 (#52673)

Co-authored-by: Ubuntu <cloudtest@c024656fc00000I.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>

* Add link to customization docs (#52686)

* Add link to customization docs

* delete docs

* fix script

* Add confirmation before sdk generation (#52685)

Co-authored-by: Summer Warren <[email protected]>

* Update commit (#52690)

* update commit and directory (#52693)

* Regenerate repository SDK with TypeSpec build 20250917.2 (#52692)

Co-authored-by: azure-sdk <[email protected]>

* Fix namespace for `Azure.ResourceManager.Compute.Recommender` (#52696)

* [Conv runtime] remove conersationai 20250515preview (#52651)

* generated new sdk with no aiconversation

* updated tests and samples for removing aiconversation

* updated assets.json

* updated snippets

* updated Export-API.ps1

* updated changelog

* Remove Azure AD reference from Identity README (#52698)

* [Storage] Add system-assigned managed identity support to Blob perf tests (#52689)

* Sync eng/common directory with azure-sdk-tools repository (#52702)

* Sync eng/common directory with azure-sdk-tools for PR 11968 (#52704)

* Add copilot instruction for package name properties in typespec config

* Update eng/common/instructions/azsdk-tools/sdk-details-in-release-plan.instructions.md

---------

Co-authored-by: Praveen Kuttappan <[email protected]>
Co-authored-by: Praven Kuttappan <[email protected]>

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250918.1 (#52708)

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20250918.1

* regen

---------

Co-authored-by: Ubuntu <cloudtest@8134ce55c00000D.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: jolov <[email protected]>

* [Microsoft.ClientModel.TestFramework] Remove some flaky tests that aren't helpful (#52709)

* Remove flaky tests from RecordedTestBaseTests that aren't that helpful

Removed delay-related tests for RecordedTestBase.

* Remove async processing test from TestUtilitiesIntegrationTests

Removed the test for async processing in MockTransport.

* Specified build command in the configuration for .NET again

This reverts commit fd4b2d1.

* Prepare for the release (#52715)

* Sync eng/common directory with azure-sdk-tools for PR 11868 (#52707)

* added instructions for sdk local workflow

* fix case

* Added missing comma

* Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Replace 'tspconfigPath' by the literal file name

* Added routing step to choose workflow

* Added goal and action to some steps properly

* Specified mcp tool name explicitly

* Added back step to choose sdk generation approach

* Specified the mcp tool names explicitly

* Update eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Co-authored-by: Mariana Rios Flores <[email protected]>

---------

Co-authored-by: ray chen <[email protected]>
Co-authored-by: Mariana Rios Flores <[email protected]>

* Update commit IDs to reference specs with emitter-output-dir (#52699)

* Update commit IDs to reference specs with emitter-output-dir

* regen

* fix build

* sr

* regen

* Add backcompat method

* re-record tests

* tests

* API

* fix commit

* Increment package version after release of Azure.AI.Agents.Persistent (#52718)

* Increment package version after release of Azure.AI.Language.Conversations (#52703)

* Sync eng/common directory with azure-sdk-tools for PR 12060 (#52711)

* pin tsp-client

* Added a script to wrap the call to tsp-client

* Used npm i to improve per

* Removed script and added readme.md

* Update eng/common/tsp-client/README.md

Co-authored-by: Mike Harder <[email protected]>

* Update eng/common/tsp-client/README.md

Co-authored-by: Mike Harder <[email protected]>

* Use npm ci for installation

* Added dependabot to readme

* Update eng/common/tsp-client/README.md

Co-authored-by: Mike Harder <[email protected]>

* Removed 'prefix' option approach from usage

* Fixed format issue

---------

Co-authored-by: catalinaperalta <[email protected]>
Co-authored-by: ray chen <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* update

* update

---------

Co-authored-by: Jacob Lauzon <[email protected]>
Co-authored-by: Prajjwal Kamboj <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Rajkumar Rangaraj <[email protected]>
Co-authored-by: Anthony Martin <[email protected]>
Co-authored-by: Nneka Okeke <[email protected]>
Co-authored-by: Wei Hu <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Weishu Zhao <[email protected]>
Co-authored-by: Ubuntu <cloudtest@cd62265fc00000I.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Amanda Nguyen <[email protected]>
Co-authored-by: Christopher Radek <[email protected]>
Co-authored-by: Ubuntu <cloudtest@88659a30c00000J.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: Aanund Austrheim <[email protected]>
Co-authored-by: haiyuan_zhang <[email protected]>
Co-authored-by: Ubuntu <cloudtest@e0ee3965c000007.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Maddy Heaps <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Ubuntu <cloudtest@632c522dc000005.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Christopher Scott <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: jolov <[email protected]>
Co-authored-by: Nikolay Rovinskiy <[email protected]>
Co-authored-by: Drishti Peshwani <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: davo7135 <[email protected]>
Co-authored-by: Summer Warren <[email protected]>
Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Ryan Hurey <[email protected]>
Co-authored-by: ksemenov-gh <[email protected]>
Co-authored-by: Konstantin Semenov <[email protected]>
Co-authored-by: Elina Liu <[email protected]>
Co-authored-by: Avinash Ranjan <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: azure-sdk <[email protected]>
Co-authored-by: Athrva Udapure <[email protected]>
Co-authored-by: Atharva Udapure <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: Nick Liu <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: Kashish Gupta <[email protected]>
Co-authored-by: ddouglas-msft <[email protected]>
Co-authored-by: ArcturusZhang <[email protected]>
Co-authored-by: Wenming Liu <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: Ubuntu <cloudtest@c024656fc00000I.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: amber-Chen-86 <[email protected]>
Co-authored-by: Scott Addie <[email protected]>
Co-authored-by: Praveen Kuttappan <[email protected]>
Co-authored-by: Praven Kuttappan <[email protected]>
Co-authored-by: Ubuntu <cloudtest@8134ce55c00000D.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: catalinaperalta <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This massive pull request for ".NET SDK Network Generation API Version 2024-10-01" consolidates multiple changes across the Azure .NET SDK repository. The main purpose is to update network-related SDKs to a new API version while also including numerous fixes, improvements, and updates to various Azure AI SDKs.

Key changes include:

  • Updates to Azure.AI.VoiceLive SDK with new version 1.0.0-beta.2, including API improvements and bug fixes
  • Enhancements to Azure.AI.Agents.Persistent with better telemetry testing and bug fixes
  • Updates to Azure.AI.Projects SDK configuration and dependencies
  • Generator improvements for TypeSpec emitter support and dependency updates

Reviewed Changes

Copilot reviewed 91 out of 2211 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/ai/Azure.AI.VoiceLive/src/Customizations/*.cs API improvements and customizations for VoiceLive SDK
sdk/ai/Azure.AI.VoiceLive/src/Azure.AI.VoiceLive.csproj Version bump to 1.0.0-beta.2
sdk/ai/Azure.AI.VoiceLive/api/*.cs API surface changes and new types
sdk/ai/Azure.AI.Agents.Persistent/tests/*.cs Test improvements and telemetry enhancements
sdk/ai/Azure.AI.Projects/src/*.cs Configuration and dependency updates
eng/scripts/automation/*.ps1 Build script improvements for TypeSpec emitter support
eng/packages/http-client-csharp/package.json Dependency updates for generator packages
Files not reviewed (5)
  • eng/azure-typespec-http-client-csharp-emitter-package-lock.json: Language not supported
  • eng/azure-typespec-http-client-csharp-mgmt-emitter-package-lock.json: Language not supported
  • eng/common/tsp-client/package-lock.json: Language not supported
  • eng/emitter-package-lock.json: Language not supported
  • eng/http-client-csharp-emitter-package-lock.json: Language not supported

Comment on lines 33 to 36

var s = VoiceInternal.ToString();

return null;
Copy link
Preview

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getter for the Voice property converts VoiceInternal to string but then ignores the result and always returns null. This appears to be incomplete implementation and will not return the actual voice value.

Suggested change
var s = VoiceInternal.ToString();
return null;
return VoiceProvider.FromBinaryData(VoiceInternal);

Copilot uses AI. Check for mistakes.

Comment on lines 101 to 103
public ResponseMaxOutputTokensOption MaxOutputTokens
{
get;
Copy link
Preview

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MaxOutputTokens property has only a getter with no implementation body. This will not compile as there's no backing field or expression body to provide a value.

Suggested change
public ResponseMaxOutputTokensOption MaxOutputTokens
{
get;
private readonly ResponseMaxOutputTokensOption _maxOutputTokens;
public ResponseMaxOutputTokensOption MaxOutputTokens
{
get { return _maxOutputTokens; }

Copilot uses AI. Check for mistakes.


var token = await _tokenCredential.GetTokenAsync(tokenOptions, cancellationToken).ConfigureAwait(false);
clientWebSocket.Options.SetRequestHeader("Authorization", $"Bearer {token.Token}");
clientWebSocket.Options.SetRequestHeader("Authorization", $"{token.TokenType} {token.Token}");
Copy link
Preview

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using token.TokenType instead of a hardcoded 'Bearer' could be problematic if TokenType is null or not a valid authorization scheme. Consider validating the token type or defaulting to 'Bearer' for OAuth tokens.

Suggested change
clientWebSocket.Options.SetRequestHeader("Authorization", $"{token.TokenType} {token.Token}");
// Validate token type; default to "Bearer" if null, empty, or not a valid scheme
string scheme = string.IsNullOrWhiteSpace(token.TokenType) ? "Bearer" : token.TokenType;
clientWebSocket.Options.SetRequestHeader("Authorization", $"{scheme} {token.Token}");

Copilot uses AI. Check for mistakes.


// Now serialize the array of JsonElements into a single BinaryData for the request:
var jsonString = JsonSerializer.Serialize(contentBlocks, JsonElementSerializer.Default.ListJsonElement);
var jsonString = JsonSerializer.Serialize(jsonElements, JsonElementSerializer.Default.ListJsonElement);
Copy link
Preview

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name was changed from 'contentBlocks' to 'jsonElements' but 'jsonElements' is not defined in the visible scope. This appears to be referencing an undefined variable which would cause a compilation error.

Suggested change
var jsonString = JsonSerializer.Serialize(jsonElements, JsonElementSerializer.Default.ListJsonElement);
var jsonString = JsonSerializer.Serialize(jsonElements);

Copilot uses AI. Check for mistakes.

@kamboj-prjwl kamboj-prjwl changed the title .NET SDK Network Generation API Version 2024-10-01 (#52564) .NET SDK Release Network API Version 2024-10-01 Sep 19, 2025
@kamboj-prjwl kamboj-prjwl reopened this Sep 19, 2025
@github-project-automation github-project-automation bot moved this from Done to Untriaged in Azure SDK for Key Vault Sep 19, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure SDK for Key Vault Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Model Inference AI Projects App Configuration Azure.ApplicationModel.Configuration ARM Azure.Core Azure.Identity Client This issue is related to a non-management package CodeGen Issues that relate to code generation Cognitive - Language Communication Event Grid Grafana Hardware Security Modules Health Deidentification HybridConnectivity KeyVault Mgmt This issue is related to a management package. Monitor - Exporter Monitor OpenTelemetry Exporter Monitor Monitor, Monitor Ingestion, Monitor Query OpenAI Schema Registry Search Self Help SignalR Storage Storage Service (Queues, Blobs, Files) Synapse Voice Live Workload Orchestration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant