Skip to content

Conversation

live1206
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 01:55
@github-actions github-actions bot added CodeGen Issues that relate to code generation Mgmt This issue is related to a management package. labels Sep 10, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the collection property initialization mechanism in the Azure Management Generator by removing internal setters and transitioning to constructor-based initialization. The changes simplify the handling of collection-type properties during flattening.

Key changes:

  • Replaced method-based initialization with direct constructor initialization for collection properties
  • Simplified collection property tracking from dictionary of lists to a simple set
  • Removed unnecessary initialization method generation and property setter modifications

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.

File Description
FlattenPropertyVisitor.cs Refactored collection property initialization logic, removed initialization method generation, and simplified property tracking
PropertyHelpers.cs Updated getter logic to handle collection types without null checks and removed unused collection property population method

@Azure Azure deleted a comment from azure-pipelines bot Sep 10, 2025
@live1206 live1206 merged commit 17d0414 into Azure:main Sep 11, 2025
21 checks passed
@live1206 live1206 deleted the tweak-collection-type-property branch September 11, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CodeGen Issues that relate to code generation Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants