Skip to content

Conversation

reinecke
Copy link
Collaborator

@reinecke reinecke commented May 14, 2020

Somehow lint started failing for people on a lot of their branches due to issues in master, here is one such example: https://travis-ci.com/github/PixarAnimationStudios/OpenTimelineIO/jobs/333466701

Worth noting, there was one function in the kdenlive adapter I didn't know the correct fix for so I just muted the warning. This is likely broken and will require someone with more experience in that realm to address:

def write_keyframes(kfdict):
    """Build a MLT keyframe string"""
    # TODO: The following line is causing a lint error:
    #       F524 '...'.format(...) is missing argument(s) for placeholder(s): 1
    # This will likely cause an exception at runtime and should be addressed.
    return ';'.join('{}={}'.format(str(int(t.value))).format(v)  # noqa: F524
                    for t, v in kfdict.items())

@reinecke reinecke requested review from ssteinbach and jminor May 14, 2020 20:04
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, although I think the format line should be addressed, as my read of what is intended there suggests to (non-python guru) me that it's actually incorrect as opposed to merely annoying the linter.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for cleaning this up.

@reinecke
Copy link
Collaborator Author

After discussion, going ahead and merging despite the unaddressed issue in the kdenlive adapter, filed issue as #703 instead.

@reinecke reinecke merged commit e7a52a4 into AcademySoftwareFoundation:master May 14, 2020
@reinecke reinecke deleted the fix/lint-issues branch May 14, 2020 22:54
@ssteinbach ssteinbach added this to the Public Beta 13 milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants