Skip to content

Kdenlive adapter: write_keyframes function needs attention #703

@reinecke

Description

@reinecke

The write_keyframes function started failing builds due to a lint issue (see #702). The expression str(int(t.value))).format(v) seems like it's unlikely to be correct. An integer converted to a string would never be a useful format template so it's unclear what the code is attempting to do.
Additionally the outer format on for the string "{}={}" is being passed a single value (a generator) rather than two values.

Code below:

def write_keyframes(kfdict):
    """Build a MLT keyframe string"""
    return ';'.join('{}={}'.format(str(int(t.value))).format(v)  # noqa: F524
                    for t, v in kfdict.items())

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions