Skip to content

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented May 21, 2022

Fixes #1310 .

This PR updates the Pybind11 version to 2.9.2.

I cd'ed into src/deps/pybind11 and git checkout v2.9.2.

@codecov-commenter
Copy link

Codecov Report

Merging #1312 (68b683c) into main (a58b0fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files         195      195           
  Lines       19806    19806           
  Branches     2313     2313           
=======================================
  Hits        17068    17068           
  Misses       2174     2174           
  Partials      564      564           
Flag Coverage Δ
py-unittests 86.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58b0fc...68b683c. Read the comment docs.

@meshula
Copy link
Collaborator

meshula commented May 23, 2022

Does this cover the same thing as dependabot, or are you after a specific commit? #1315

@JeanChristopheMorinPerso
Copy link
Member Author

@meshula #1315 updates to the tip of pybind11's main branch while my PR specifically picks the commit that corresponds to 2.9.2.

The tip of pybind11's main branch is no more compatible with Python 2.

@JeanChristopheMorinPerso
Copy link
Member Author

JeanChristopheMorinPerso commented May 23, 2022

For reference, Dependabot doesn't support git tags for git submodules, see dependabot/dependabot-core#1639. It will only update to the latest commit.

@meshula
Copy link
Collaborator

meshula commented May 23, 2022

Ah, right. Could you amend the commit comment with some notes along the lines in the issue? Something about "We are lagging behind a little bit in terms of Pybind11 versions. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7."

@JeanChristopheMorinPerso
Copy link
Member Author

JeanChristopheMorinPerso commented May 23, 2022

Done. I went with "Manually update Pybind11 to 2.9.2 since dependabot doesn't support git tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7."

…t tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@meshula
Copy link
Collaborator

meshula commented May 23, 2022

Great, thanks!

@meshula meshula merged commit e7b427e into AcademySoftwareFoundation:main May 23, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the update_pybind11 branch May 23, 2022 23:55
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…t tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7. (AcademySoftwareFoundation#1312)

Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pybind11 to 2.9.2
4 participants