-
Notifications
You must be signed in to change notification settings - Fork 309
Update Pybind11 to 2.9.2 #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pybind11 to 2.9.2 #1312
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 86.17% 86.17%
=======================================
Files 195 195
Lines 19806 19806
Branches 2313 2313
=======================================
Hits 17068 17068
Misses 2174 2174
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Does this cover the same thing as dependabot, or are you after a specific commit? #1315 |
For reference, Dependabot doesn't support git tags for git submodules, see dependabot/dependabot-core#1639. It will only update to the latest commit. |
Ah, right. Could you amend the commit comment with some notes along the lines in the issue? Something about "We are lagging behind a little bit in terms of Pybind11 versions. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7." |
68b683c
to
9280df3
Compare
Done. I went with "Manually update Pybind11 to 2.9.2 since dependabot doesn't support git tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7." |
…t tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7. Signed-off-by: Jean-Christophe Morin <[email protected]>
9280df3
to
af37802
Compare
Great, thanks! |
…t tags and updates to the latest commit of pybind11. The 2.9 series is the last to support Python 2.7. Pybind11 2.10 will drop support for Python 2.7. (AcademySoftwareFoundation#1312) Signed-off-by: Michele Spina <[email protected]>
Fixes #1310 .
This PR updates the Pybind11 version to 2.9.2.
I cd'ed into
src/deps/pybind11
andgit checkout v2.9.2
.