-
Notifications
You must be signed in to change notification settings - Fork 309
Improve Python reference documentation #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Python reference documentation #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! I made some edits in several places that will hopefully make some things more clear.
src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentimelineio-bindings/otio_serializableObjects.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentimelineio-bindings/otio_serializableObjects.cpp
Outdated
Show resolved
Hide resolved
src/py-opentimelineio/opentimelineio-bindings/otio_serializableObjects.cpp
Outdated
Show resolved
Hide resolved
325ad9a
to
e3cb83f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 86.14% 86.11% -0.03%
==========================================
Files 196 196
Lines 19813 19822 +9
Branches 2314 2316 +2
==========================================
+ Hits 17068 17070 +2
- Misses 2181 2186 +5
- Partials 564 566 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @jminor for the review! I addressed all your comments and suggestions and I also completed what I wanted to do. The ReadTheDocs setup should be much more reliable now because the dependencies required to build the docs are now pinned to specific versions. So the PR is now officially ready for more reviews. |
It's also good to note that there is only 2 Sphinx warnings left when building the docs :)
To remove the first warning, we would need to shuffle the order of the code in For the second warning, we would need to update to Pybind11 2.9.1 where we are interested in |
Alright, I fixed the |
src/py-opentimelineio/opentimelineio-bindings/otio_serializableObjects.cpp
Show resolved
Hide resolved
45730ac
to
536ab0b
Compare
I pushed new commits that address the PR comments I had from @meshula and there is also a new GitHub action workflow that checks for dead links in the docs. I had to rebase all commits because of DCO and fix merge conflicts. |
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 86.20% 86.17% -0.03%
==========================================
Files 196 196
Lines 19839 19848 +9
Branches 2317 2319 +2
==========================================
+ Hits 17103 17105 +2
- Misses 2170 2175 +5
- Partials 566 568 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I create a PR to update Pybind11 to 2.9.2, see #1312 . Hopefully it will be merged before we merge this current PR so that I can add a new job to check for Sphinx warnings in CI. |
536ab0b
to
de766fd
Compare
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
…to MyST Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
…remove. Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
de766fd
to
d4774b0
Compare
@jminor @meshula (I wish there was a TSC tag... There is only the committer tag which includes John Mertic...), Gentle ping on this PR. I just added the job that checks if there is any build error/warning as I said previously. This PR is now pretty much done from my point of view, unless someone wants to do another review pass at the docstrings or anything else? |
This looks great, thanks @JeanChristopheMorinPerso ! One (non blocking) question- do you know why some headers appear twice on mobile? |
Good question @ssteinbach ! Both pages seem to contain the same section names. When you click on the sections, the content is different, so they don't seem duplicated. Does that make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is a great change. Thanks for working through this!
Thanks for the reviews and accepting the pull request! 🎉✨ |
* Improve Python reference documentation * Fix lint * Add some missing docstrings * Use new ReadTheDocs config format, bake sphinx dependencies and move to MyST * Re-generate plugins and schema docs * Add spatial coordinates doc to main doctree * Simplify the process for building the docs locally * Fix Sphinx warnings * enable GH builds * Modify make.bat to match with the docs Makefile * Add job to detect doc warnings/errors Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Link the Issue(s) this Pull Request is related to.
Relates to #704 (and maybe others, I haven't searched extensively).
Summarize your change.
This PR refreshes the Python API reference documentation.
The rendered version can be found at https://jcmorin-opentimelineio.readthedocs.io/en/latest/index.html.
Changes are:
sphinx-apidoc
command to usingsphinx.ext.autosummary
. This gives better control over the generated documentation and improves the user experience.self
argument is stripped off as it's useless.recommonmark
is deprecated.docs/requirements.txt
.