Skip to content

Conversation

jminor
Copy link
Collaborator

@jminor jminor commented Sep 2, 2021

This change adds the OTIO Technical Steering Committee Charter.

@codecov-commenter
Copy link

Codecov Report

Merging #1057 (a1a97ff) into master (42d7297) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files         191      191           
  Lines       19004    19004           
  Branches     2105     2105           
=======================================
  Hits        16406    16406           
  Misses       2052     2052           
  Partials      546      546           
Flag Coverage Δ
unittests 86.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d7297...a1a97ff. Read the comment docs.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some master->main changes, also can we rebase just to make sure its all up to date?

meshula and others added 3 commits October 28, 2021 11:43
Co-authored-by: Stephan Steinbach <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]>
@meshula
Copy link
Collaborator

meshula commented Oct 28, 2021

Your edits master->main are committed

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 a few more slipped through.

I was going to suggest using git switch rather than git checkout commands, but looking at the documentation for git switch, it notes that that is still an experimental command. At some point in the future though, we should change those instructions over.

meshula and others added 4 commits October 29, 2021 13:08
Co-authored-by: Stephan Steinbach <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]>
@meshula
Copy link
Collaborator

meshula commented Oct 29, 2021

@ssteinbach I've committed your suggestions. I think to clear the red flags, you need to manually approve the PR.

@ssteinbach
Copy link
Collaborator

@meshula this is looking good now; I'd still like it if it was rebased before we landed it just to 100% make sure we didn't get some cruft in there.

@jminor
Copy link
Collaborator Author

jminor commented Oct 29, 2021

I used the "fetch & merge" button instead of rebase. I think this is ready to land now. Can you double-check @ssteinbach ?

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ssteinbach ssteinbach merged commit 27ed986 into AcademySoftwareFoundation:main Nov 3, 2021
@jminor jminor deleted the tsc branch February 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants