-
Notifications
You must be signed in to change notification settings - Fork 309
Open
Labels
Description
Following discussion from: #1387
The python binding for the registration system for types and up/downgrade functions currently returns a bool:
TypeRegistry::instance().register_type(schema_name, schema_version, return TypeRegistry::instance().register_upgrade_function(schema_name, version_to_upgrade_to,
However, the bindings have a system for capturing these results and raising exceptions. I briefly experimented with this during the development of #1387, but it seems like the python unit tests assume that its ok to double register the same type without it triggering an exception.
For unit testing this probably means additional functions that allow un-registering types from the TypeRegistry
.
I think the action items are:
- discuss at a TSC meeting whether this would be desired behavior,
- ...and if so what exception should be raised