Skip to content

Commit 424967a

Browse files
authored
Fixes and improvements for Kdenlive adapter (#1390)
* Add global marker import/export * Add unsupported clip placeholder only if needed * [Kdenlive adapter] Refactor, fix and extend - Add support for SMPTE bars (read and write) - Fix reading of projects with "mixes" (only reading yet) - Add support for clip markers (only reading yet) - Move some code parts to functions to improve readability, reusablity and testability. * [Kdenlive adapter] extend tests * [Kdenlive adapter] Fix linting * Update plugin documentation after Kdenlive adapter update Signed-off-by: Julius Künzel <[email protected]>
1 parent 5b418db commit 424967a

File tree

7 files changed

+2870
-119
lines changed

7 files changed

+2870
-119
lines changed

contrib/opentimelineio_contrib/adapters/kdenlive.py

Lines changed: 324 additions & 117 deletions
Large diffs are not rendered by default.
Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
{
2+
"OTIO_SCHEMA": "Timeline.1",
3+
"metadata": {},
4+
"name": "transition_test",
5+
"tracks": {
6+
"OTIO_SCHEMA": "Stack.1",
7+
"children": [
8+
{
9+
"OTIO_SCHEMA": "Sequence.1",
10+
"children": [
11+
{
12+
"OTIO_SCHEMA": "Clip.1",
13+
"effects": [],
14+
"markers": [],
15+
"enabled": true,
16+
"media_reference": {
17+
"OTIO_SCHEMA" : "GeneratorReference.1",
18+
"available_range" : {
19+
"OTIO_SCHEMA": "TimeRange.1",
20+
"duration": {
21+
"OTIO_SCHEMA": "RationalTime.1",
22+
"rate": 24,
23+
"value": 50
24+
},
25+
"start_time": {
26+
"OTIO_SCHEMA": "RationalTime.1",
27+
"rate": 24,
28+
"value": 0.0
29+
}
30+
},
31+
"generator_kind" : "SMPTEBars",
32+
"metadata" : {},
33+
"parameters" : {},
34+
"name" : "bars"
35+
},
36+
"metadata": {},
37+
"name": "C",
38+
"source_range": {
39+
"OTIO_SCHEMA": "TimeRange.1",
40+
"duration": {
41+
"OTIO_SCHEMA": "RationalTime.1",
42+
"rate": 24,
43+
"value": 50
44+
},
45+
"start_time": {
46+
"OTIO_SCHEMA": "RationalTime.1",
47+
"rate": 24,
48+
"value": 0.0
49+
}
50+
}
51+
52+
}
53+
],
54+
"effects": [],
55+
"kind": "Video",
56+
"markers": [],
57+
"enabled": true,
58+
"metadata": {},
59+
"name": "Sequence1",
60+
"source_range": null
61+
}
62+
],
63+
"effects": [],
64+
"markers": [],
65+
"enabled": true,
66+
"metadata": {},
67+
"name": "tracks",
68+
"source_range": null
69+
}
70+
}

contrib/opentimelineio_contrib/adapters/tests/sample_data/kdenlive_example.kdenlive renamed to contrib/opentimelineio_contrib/adapters/tests/sample_data/kdenlive_example_v191180.kdenlive

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@
264264
<property name="kdenlive:folderid">-1</property>
265265
<property name="kdenlive:id">10</property>
266266
<property name="kdenlive:file_hash">de362639624a26f69e4278e90d059408</property>
267+
<property name="kdenlive:clipname">Placeholder: Unsupported clip type</property>
267268
<property name="force_reload">0</property>
268269
<property name="meta.media.width">768</property>
269270
<property name="meta.media.height">576</property>

contrib/opentimelineio_contrib/adapters/tests/sample_data/kdenlive_example_v221170.kdenlive

Lines changed: 1065 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)