Add basic support for Microchip PIC32CX SG Family devices #96301

mchp-asif · 2025-09-19T16:40:37Z

This PR adds initial support for Microchip’s PIC32CX SG family of SoCs, along with board support for the PIC32CX SG61 Curiousity Ultra development kit (EV09H35A). It includes the basic SoC integration, devicetree files, and minimal configuration needed to bring up the board with a working blinky.

github-actions · 2025-09-19T16:41:22Z

Hello @mchp-asif, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-09-19T16:41:40Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dts/arm/microchip/pic32c/pic32cx_sg/common/pic32cx_sg.dtsi

nordicjm · 2025-09-22T09:51:14Z

soc/microchip/pic32c/pic32cx_sg/Kconfig.soc

+# List of Peripheral IPs available in SOC_FAMILY_MICROCHIP_PIC32CX_SG family
+config PINCTRL_MCHP_PORT_U2210_2_2_0
+	bool
+	default y
+	help
+	  Enable PORT pinctrl peripheral IP version 2.2.0 (U2210).


this does not belong in Kconfig.soc

#93450 (comment)

The symbol is added similar to the one in above link. It is used for specifying the peripheral ip which is present on the soc. It can be used in the kconfig file of respective driver if any conditional compilation is required in the common driver.

right I missed that seemingly, https://github.com/zephyrproject-rtos/zephyr/pull/93450/files#diff-c050e37ce12edcb8c94981ec35cd65f13a03f132924e4401f65ecd62a5c43b99R11 these need to go out of Kconfig.soc and put them in Kconfig

Just to be sure, you meant to put these symbols inside soc/microchip/pic32c/pic32cx_sg/Kconfig right? or do you mean to put them inside the driver specific kconfig file?

Can you please tell me why it is to be moved to the kconfig?

Added a comment to another PR but what is this for? There is a Kconfig already which is auto generated for knowing if a device is present, why do you need another Kconfig for this?

Okay @nordicjm. I will explore this option. Meanwhile can you please tell me the reason behind this approach, it will help me better resolve the issue.

DTS describes hardware, a v1 or v2 peripheral is hardware differences and is not software selectable, Kconfig is for software configuration. Also see linux kernel e.g. Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml and Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvdec.yaml or ./Documentation/devicetree/bindings/interrupt-controller/arm,gic-v5.yaml and ./Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml

Thank You @nordicjm for the clarification. Currently the driver is not using this symbol, so for the time being I shall remove it.

Further, I will explore more into the options you shared for adding support for multiple peripheral versions inside the same driver.

Hope this approach is fine.

Removing it is fine (it has not been removed)

@nordicjm I have removed it now. Just was waiting for your confirmation.

boards/microchip/pic32c/pic32cx_sg61_cult/pic32cx_sg61_cult.dts

nordicjm · 2025-09-22T09:52:03Z

boards/microchip/pic32c/pic32cx_sg61_cult/pic32cx_sg61_cult_defconfig

+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_BUILD_OUTPUT_HEX=y
+CONFIG_ARM_MPU=y


UART missing?

There is no UART in the dtsi yet.
I think they will add later.

Yes. As @nandojve rightly said, it is not added now. It will be added later.

nandojve · 2025-09-22T15:36:02Z

west.yml

        - hal
    - name: hal_microchip
-      revision: e5fe6469afc53d7aefcc74377dd99ce20428d42b
+      revision: 651b61316816271949620b6c7e8e666f271e15ca


I'll mark to DNM until we finish the review to avoid ping pong in the hash.

okay @nandojve

nandojve · 2025-09-22T15:41:03Z

boards/microchip/pic32c/pic32cx_sg61_cult/pic32cx_sg61_cult_defconfig

+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_BUILD_OUTPUT_HEX=y
+CONFIG_ARM_MPU=y


There is no UART in the dtsi yet.
I think they will add later.

nordicjm · 2025-09-25T06:18:21Z

think this might need a rebase

Adds common and SoC-specific .dtsi files for the Microchip PIC32CX SG family. These files define core peripherals, address maps, and interrupt controller structure shared across the PIC32CX SG variants. Signed-off-by: Muhammed Asif <[email protected]>

mchp-asif · 2025-09-25T07:08:42Z

think this might need a rebase
@nordicjm
I have rebased with the latest. Could you please check and approve?

mchp-asif · 2025-09-25T09:32:19Z

@nandojve Could you please remove the DNM tag as I have removed the commit updating the west.yml from this PR?

Adds initial SoC-level support for the Microchip PIC32CX SG series, including SoC definition files. Signed-off-by: Muhammed Asif <[email protected]>

…pport Add initial support for the Microchip PIC32CX SG61 Curiosity Pro board Product page: https://www.microchip.com/en-us/development-tool/ev09h35a Signed-off-by: Muhammed Asif <[email protected]>

sonarqubecloud · 2025-09-25T11:41:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot added manifest manifest-hal_microchip labels Sep 19, 2025

zephyrbot added platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Sep 19, 2025

zephyrbot requested review from albertofloyd, jvasanth1, nandojve, scottwcpg and VenkatKotakonda September 19, 2025 16:42

zephyrbot assigned jvasanth1, scottwcpg and nandojve Sep 19, 2025

nordicjm requested changes Sep 22, 2025

View reviewed changes

nandojve requested changes Sep 22, 2025

View reviewed changes

nandojve added the DNM This PR should not be merged (Do Not Merge) label Sep 22, 2025

nandojve added this to the v4.3.0 milestone Sep 22, 2025

mchp-asif force-pushed the map_pic32cx_minimal_support branch 2 times, most recently from d69cb71 to e817f80 Compare September 22, 2025 18:27

mchp-asif requested review from nandojve and nordicjm September 22, 2025 18:59

mchp-asif force-pushed the map_pic32cx_minimal_support branch 2 times, most recently from 8f04b78 to f33ff21 Compare September 25, 2025 03:58

zephyrbot added platform: ADI Analog Devices, Inc. platform: Silabs Silicon Labs labels Sep 25, 2025

zephyrbot requested review from asmellby, jerome-pouiller, jhedberg and MaureenHelm September 25, 2025 04:02

zephyrbot requested review from ozersa, petejohanson-adi, ttmut and yasinustunerg September 25, 2025 04:02

nordicjm previously approved these changes Sep 25, 2025

View reviewed changes

mchp-asif dismissed nordicjm’s stale review via 5a014a0 September 25, 2025 06:42

mchp-asif force-pushed the map_pic32cx_minimal_support branch from f33ff21 to 5a014a0 Compare September 25, 2025 06:42

mchp-asif force-pushed the map_pic32cx_minimal_support branch from 5a014a0 to 8ce400e Compare September 25, 2025 07:06

github-actions bot removed manifest manifest-hal_microchip labels Sep 25, 2025

fabin-mchp mentioned this pull request Sep 25, 2025

drivers: flash: mchp: Introduce G1 Flash Driver #96075

Open

mchp-asif requested a review from nordicjm September 25, 2025 07:08

mchp-asif added 2 commits September 25, 2025 16:33

soc: microchip: Add support for PIC32CX SG SoC series

1ef5717

Adds initial SoC-level support for the Microchip PIC32CX SG series, including SoC definition files. Signed-off-by: Muhammed Asif <[email protected]>

boards: microchip: add PIC32CX SG61 Curiosity Ultra Evaluation Kit su…

e52d784

…pport Add initial support for the Microchip PIC32CX SG61 Curiosity Pro board Product page: https://www.microchip.com/en-us/development-tool/ev09h35a Signed-off-by: Muhammed Asif <[email protected]>

mchp-asif force-pushed the map_pic32cx_minimal_support branch from 8ce400e to e52d784 Compare September 25, 2025 11:14

Add basic support for Microchip PIC32CX SG Family devices #96301

Are you sure you want to change the base?

Add basic support for Microchip PIC32CX SG Family devices #96301

Conversation

mchp-asif commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mchp-asif Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm commented Sep 25, 2025

Uh oh!

mchp-asif commented Sep 25, 2025

Uh oh!

mchp-asif commented Sep 25, 2025

Uh oh!

sonarqubecloud bot commented Sep 25, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025 •

edited

Loading

mchp-asif Sep 23, 2025 •

edited

Loading

nordicjm Sep 23, 2025 •

edited

Loading