This repository is currently being migrated. It's locked while the migration is in progress.
OPENRESTY-127 HTTPS healthchecks issue #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrakaGytis
force-pushed
the
feature/OPENRESTY-127_https_healthchecks_issue
branch
from
f4f53a0 to
46ce700
Compare
DrakaGytis
force-pushed
the
feature/OPENRESTY-127_https_healthchecks_issue
branch
from
46ce700 to
b91ba36
Compare
|
Works great, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that fails on ssl handshake makes healthchecks to stop working.
The fix seems to fix the issue (I was not able to reproduce it). The issue was that if the ssl fails the connection is not set as failed. The health check thinks that the connection is valid and waits till it is resolved. However, internally the connection is dropped and the callback functions are not run (which should check the connection), leaving the health check status not changed.