LUA-656 added support for ssl (e.g., HTTPS) #2
Conversation
|
hey @kipras, could you please review this? Thanks! |
| @@ -241,6 +242,7 @@ struct ngx_http_upstream_check_srv_conf_s { | |||
| ngx_array_t *fastcgi_params; | |||
|
|
|||
| ngx_uint_t default_down; | |||
| ngx_uint_t ssl; | |||
There was a problem hiding this comment.
This looks like a boolean flag, so perhaps we can use ngx_uint_t ssl:1; here?
There was a problem hiding this comment.
Yes, it's a boolean. Unfortunately, Nginx doesn't define (or use the standard) boolean type. I think using bit fields would make sense for a collection of flags, not for a single one.
There was a problem hiding this comment.
True, but if there was another boolean flag to be added - the we wouldn't have to modify this one :)
Also, default_down looks like a boolean flag too.
But anyway, this is a very minor thing and can be skipped :)
There was a problem hiding this comment.
Indeed for having both default_down and ssl, but I would skip this change to avoid changing unnecessary things. IMHO, it makes it hard to sync with upstream.
|
Looks great, i didn't test it though. |
No description provided.