This repository was archived by the owner on Sep 5, 2022. It is now read-only.
Fixes URLs with query strings and hashes in them #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix did not test a corner case where the user passes extensions allowed in the options. When there are no otpions passed for extensions allowed the extension check is skipped and thus the file is processed appropriately. I added virtual copies of the tests so feel free to point me to a better way of doing that. I just don't know what a better way to do it is without overwriting the original tests. The fix I made was stripping query strings and hashes from the regex results before the extension check and then passing in that stripped version into the check instead of the actual result which has the hash and/or query string.
|
Thank you and good catch 👍. #31 can be closed ? |
zckrs
pushed a commit
that referenced
this pull request
Dec 23, 2015
Fixes URLs contains query strings or hashes with extension option
|
Released to NPM https://github.com/zckrs/gulp-css-base64/releases/tag/1.3.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix did not test a corner case where
the user passes extensions allowed in the options.
When there are no options passed for extensions
allowed the extension check is skipped and thus the
file is processed appropriately.
I added virtual copies of the tests so feel free to
point me to a better way of doing that. I just don't
know what a better way to do it is without overwriting
the original tests.
The fix I made was stripping query strings and hashes
from the regex results before the extension check and
then passing in that stripped version into the check
instead of the actual result which has the hash and/or
query string.