Bug: Urls ending with questionmark / hashtag are not base64 encoded

[peters]

Urls ending with a questionmark / hashtag are not base64 encoded, see fontawesome

@font-face {
  font-family: 'FontAwesome';
  src: url('../fonts/fontawesome-webfont.eot?v=4.2.0');
  src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.2.0') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff?v=4.2.0') format('woff'), url('../fonts/fontawesome-webfont.ttf?v=4.2.0') format('truetype'), url('../fonts/fontawesome-webfont.svg?v=4.2.0#fontawesomeregular') format('svg');
  font-weight: normal;
  font-style: normal;
}

[peters]

/cc @zckrs

[zckrs]

Please can you show me your task who use gulp-css-base64 ?

[peters]

@zckrs

['mytasks'].forEach(function(name) {
    gulp.task(name + '.css', function () {
        return gulp.src(paths[name + '.css'])
           .pipe(cssBase64(base64Options))
           .pipe(concat(name + '.css'))
           .pipe(gulp.dest('src/odinoffice.web/static/css'))
    });
    gulp.task(name + '.min.css', function () {
       return gulp.src(paths[name + '.css'])
           .pipe(cssBase64(base64Options))
           .pipe(concat(name + '.min.css'))
           .pipe(minifycss())
           .pipe(gulp.dest('src/odinoffice.web/static/css'))
           .pipe(gzip(gzipOptions))
           .pipe(gulp.dest('src/odinoffice.web/static/css'));
    });

    gulp.task(name, [name + '.css', name + '.min.css']);

    allTasks.push(name + '.css');
    allTasks.push(name + '.min.css');

    watchPaths[name + '.css'] = paths[name + '.css'];
});

[peters]

If you remove ?v=4.2.0 from the url it works as expected.

[zckrs]

Fixed by #23
Release at 1.3.1

Thanks for issue 😃

[peters]

Awesome, thanks 👯