-
Notifications
You must be signed in to change notification settings - Fork 21
Update CatalogV1 data model with latest schema #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MetadataClass
User->>MetadataClass: Instantiate Metadata()
MetadataClass-->>User: Returns instance with dbt_version='1.10.0a1', invocation_started_at (optional)
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Pylint (3.3.7)dbt_artifacts_parser/__init__.pydbt_artifacts_parser/parsers/catalog/catalog_v1.py✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
dbt_artifacts_parser/parsers/catalog/catalog_v1.py (1)
18-21
: New metadata fields added correctly; consider parsing todatetime
for stronger typingThe default
dbt_version='1.10.0a1'
and new optionalinvocation_started_at
field align with the updated schema.
If feasible, representinggenerated_at
andinvocation_started_at
asdatetime
(usingdatetime | str
withField(..., alias=..., validate_default=True)
or a custom validator) would provide stronger type safety and automatic ISO-8601 parsing while remaining JSON-serialisable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
dbt_artifacts_parser/resources/catalog/catalog_v1.json
is excluded by!**/*.json
📒 Files selected for processing (2)
dbt_artifacts_parser/__init__.py
(1 hunks)dbt_artifacts_parser/parsers/catalog/catalog_v1.py
(1 hunks)
🔇 Additional comments (1)
dbt_artifacts_parser/__init__.py (1)
21-21
: Version bump looks good — double-check all distribution metadata is in sync
__version__
is now0.9.1
, but please verify that the same version is reflected in packaging artifacts (pyproject.toml
,setup.cfg
, release notes, CI publish workflow) to avoid mismatch during release.
User description
Updates the
CatalogV1
data model to support the latest schema changes.Changes
1.9.0b2
to1.10.0a1
invocation_started_at
field toMetadata
model0.9.1
PR Type
Enhancement
Description
Updated CatalogV1 data model to latest schema
Bumped dbt_version default from 1.9.0b2 to 1.10.0a1
Added optional invocation_started_at field to Metadata
Incremented package version to 0.9.1
Changes diagram
Changes walkthrough 📝
__init__.py
Package version bump
dbt_artifacts_parser/init.py
catalog_v1.py
Metadata model schema updates
dbt_artifacts_parser/parsers/catalog/catalog_v1.py
catalog_v1.json
JSON schema definition updates
dbt_artifacts_parser/resources/catalog/catalog_v1.json