Skip to content

Conversation

rakuco
Copy link
Collaborator

@rakuco rakuco commented Sep 9, 2025

Just setting target_os="ios" enables a WebKit-based build, which is very different from most other Chromium ports and does not help with the idea of getting more coverage for something similar to a tvOS build.

Bug: 443745131

Just setting `target_os="ios"` enables a WebKit-based build, which is very
different from most other Chromium ports and does not help with the idea of
getting more coverage for something similar to a tvOS build.

Bug: 443745131
@rakuco rakuco requested review from yell0wd0g and fayev-g September 9, 2025 09:16
@rakuco
Copy link
Collaborator Author

rakuco commented Sep 9, 2025

cc @abhijeetk @jkim-julie @Gyuyoung

Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RS LGTM, I forgot about the blink thing

@yell0wd0g yell0wd0g merged commit 3a5ec25 into youtube:main Sep 9, 2025
383 checks passed
@rakuco rakuco deleted the build-ios-with-blink branch September 9, 2025 14:17
github-actions bot pushed a commit that referenced this pull request Sep 10, 2025
Just setting `target_os="ios"` enables a WebKit-based build, which is
very different from most other Chromium ports and does not help with the
idea of getting more coverage for something similar to a tvOS build.

Bug: 443745131

original-hexsha: 3a5ec25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants