Release v0.9-rc2 #290
Merged
Release v0.9-rc2 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WaitFish 的《Docker学习手册v1.0》已归档到新的分支 |
yeasy
reviewed
Dec 9, 2017
| @@ -1,49 +0,0 @@ | |||
| # Some useful commands to use docker. | |||
| # Author: yeasy@github | |||
| # Created:2014-09-25 | |||
There was a problem hiding this comment.
Would like to suggest keep this file, as we wanna add some quick cmd alias if possible.
There was a problem hiding this comment.
该文件不是用于 进入容器一节的吗，进入容器一节已经不需要该文件了
There was a problem hiding this comment.
There was a problem hiding this comment.
没必要弄些额外的脚本，尽量用 docker 原始命令
yeasy
requested changes
Dec 9, 2017
| @@ -1,126 +0,0 @@ | |||
| # Docker命令查询 | |||
There was a problem hiding this comment.
Why need to delete this file? Instead, we should update its content, for quick cmd usage reference.
There was a problem hiding this comment.
https://github.com/yeasy/docker_practice/tree/master/appendix/command
与这个文件重复了，SUMMARY 包含的是这个，没包含根目录的 appendix_command/README.md
yeasy
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (Mandatory)
Add
docker configOnly Swarm mode #283Add
LinuxKit#287Fix issues (Optional)
Remove useless file
error in
SUMMARY.md