fix: Ensure getPermissions returns Collection and simplify logic #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The method
getPermissions
in theGateRegistrar
class returns an array, which can lead to type compatibility issues when extending this class. The expected return type should be aCollection
to match typical Laravel practices.Solution
To resolve this issue, the
getPermissions
method has been modified to always return an instance ofCollection
. The method's logic has also been simplified by using Laravel's helpers and eliminating the need for anelse
statement.Changes Made
Collection
: Adjusted the method to return aCollection
.Benefits
Collection
type.Please review this PR and tell me if everything is right so that the merge can be done.