Skip to content

Conversation

kean
Copy link

@kean kean commented Jun 28, 2024

  • Add Package.swift
  • Update Bundle usages when SWIFT_PACKAGE is defined
  • Use Objective-C names for classes in storyboards – these don't get mangled

Instead of this (crashes):

customClass="MediaEditorThumbCell" customModule="MediaEditor" customModuleProvider="target"

It's now simply this:

customClass="WPMediaEditorThumbCell"

To test:


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@kean kean force-pushed the task/spm-support branch from 95de1c4 to f3d6eba Compare June 28, 2024 12:50
@kean kean force-pushed the task/spm-support branch from 978d418 to 4f3fe29 Compare June 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants