Skip to content

Remove remaining localization scripts made unused by new tooling #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2022
Merged

Remove remaining localization scripts made unused by new tooling #7032

merged 2 commits into from
Jun 3, 2022

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 2, 2022 •
edited
Loading

Description

Removes three scripts that the new localization tooling, #6936, superseded.

Testing instructions

Nothing to test, these scripts are no longer called, in particular because of 0b48848 and c991e2a which replaced the call to the legacy ios_update_metadata action, and 066b80a which did the same for ios_localize_project. Those actions, in turn, called the helper methods directly resulting in those scripts running.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

mokagio added 2 commits June 2, 2022 14:30
@mokagio
Remove unused localize.py script
79b3053 
Made unused by 066b80a
@mokagio
Remove unused update-translation.rb and fix-translation scripts
9e90834 
Made unused by 0b48848 and
c991e2a

`update-translations.rb` called `fix-translations`
This was referenced Jun 2, 2022
Open
Draft
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7032-9e90834 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from localization-improvements-part-3-generate-and-download-strings to trunk June 3, 2022 05:03
@mokagio mokagio requested a review from a team June 3, 2022 05:36
@mokagio mokagio added category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. category: i18n Related to localization/internationalization. labels Jun 3, 2022
@mokagio mokagio added this to the 9.4 milestone Jun 3, 2022
@mokagio mokagio marked this pull request as ready for review June 3, 2022 05:36
@mokagio mokagio enabled auto-merge June 3, 2022 05:36
AliSoftware
AliSoftware approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹 🧹

@mokagio mokagio merged commit 15f9613 into trunk Jun 3, 2022
@mokagio mokagio deleted the localization-improvements-part-5-deleted-remaining-unused-scripts branch June 3, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
category: i18n Related to localization/internationalization. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mokagio @wpmobilebot @AliSoftware