feat: add MVP implementation of OpfsBackend [WPB-19426]
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is entirely untested, but fundamentally it should demonstrate the viability of this kind of approach. Note that due to the `block_on` calls, when building for wasm the user must ensure that this is running within a web worker.
coriolinus
force-pushed
the
prgn/feat/impl-storagebackend
branch
from
87b1cd3 to
d2d5a11
Compare
Adds editor configuration, a makefile, documentation, and some code adjustents to provide bindings to the `OpfsBackend` on WASM. In general, we wouldn't expect web users to construct this directly: it doesn't (yet) give them anything that they can't more conveniently get by using the relevant APIs directly. However, it's necessary to run this on a web worker, because the necessary trait is synchronous. This means that we need to support two use cases: where the "main" part of the rust code also runs on a web worker, and where it does not. Where the "main" part of the rust code runs on a web worker, then things are easy: just add this as a dependency as shown in the readme and everything stays fast and easy on the Rust side of the FFI boundary. Where the "main" part of the rust code runs on the main thread, however, then things are less easy. We need to let JS people launch this part of the code on the worker, and provide a handle which they can give to OPFS on the main thread. That handle will also implement the `StorageBackend` trait, but it will do so by communicating with the web worker. This part is not yet built. Still, having the design in mind means that we know we will need a standalone struct which can be created in JS-land, which we can then call `.handle()` on to get that handle to pass back to the main thread. So that's why we have this thing. We just need to write the handle.
coriolinus
force-pushed
the
prgn/feat/impl-storagebackend
branch
2 times, most recently
from
3fb67e1 to
046173e
Compare
We're getting closer! We have now demonstrated that initializing the wasm module can succeed. But the app still hangs on `OpfsBackend.open`. So we need to sort that.
coriolinus
force-pushed
the
prgn/feat/impl-storagebackend
branch
from
046173e to
5a8e140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely untested and has certain known pain points and inefficiencies, but fundamentally it should demonstrate the viability of this kind of approach.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.