Skip to content

Fix issue #947 #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issue #947 #948

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ec640a
Remove zstd from the Accept-Encoding HTTP header.
0x1b5b Jul 23, 2025
2ee4e90
Fix in response to PR comments.
0x1b5b Aug 4, 2025
9212f63
Merge branch 'webrecorder:main' into fix-zstd-headers
0x1b5b Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pywb/rewrite/rewriteinputreq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,13 @@ def get_req_headers(self):
if self.splits:
value = self.splits.scheme

elif not has_brotli and name == 'HTTP_ACCEPT_ENCODING' and 'br' in value:
elif name == 'HTTP_ACCEPT_ENCODING':
# if brotli not available, remove 'br' from accept-encoding to avoid
# capture brotli encoded content
# We have to remove zstd from the list of accepted encodings as warcio does not support it.
disallowed_encodings = ('zstd',) if has_brotli else ('zstd', 'br')
name = 'Accept-Encoding'
value = ','.join([enc for enc in value.split(',') if enc.strip() != 'br'])
value = ','.join([enc for enc in value.split(',') if enc.strip() not in disallowed_encodings])

elif name.startswith('HTTP_'):
name = name[5:].title().replace('_', '-')
Expand Down