Treeshake fix

.github/actions/binary-limit/action.yml

@@ -0,0 +1,20 @@
+name: Binary Size Limit
+
+description: Compare binary size with default
+
+inputs:
+  percentage-threshold:
+    description: "the"
+    default: "5"
+    required: false
+
+runs:
+  using: composite
+
+  steps:
+    - name: GitHub Script
+      uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
+      with:
+        script: |
+          const action = require("./.github/actions/binary-limit/binary-limit-script.js");
+          await action({github, context});

.github/actions/binary-limit/binary-limit-script.js

@@ -0,0 +1,113 @@
+const fs = require("node:fs");
+
+/**
+ * @param {import("@octokit/rest")} github
+ */
+module.exports = async function action({ github, context }) {
+	const commits = await github.rest.repos.listCommits({
+		owner: context.repo.owner,
+		repo: context.repo.repo,
+		per_page: 30
+	});
+
+	let baseSize = 0;
+	let baseCommit = null;
+
+	for (const commit of commits.data) {
+		console.log(commit.sha);
+		try {
+			const data = await fetchDataBySha(commit.sha);
+			if (data?.size) {
+				baseCommit = commit;
+				baseSize = data.size;
+				console.log(`Commit ${commit.sha} has binary size: ${data.size}`);
+				break;
+			}
+		} catch (e) {
+			console.log(e);
+		}
+	}
+
+	if (!baseCommit) {
+		const error = `No base binary size found within ${commits.data.length} commits`;
+		console.log(error);
+		throw new Error(error);
+	}
+
+	const headSize = fs.statSync(
+		"./crates/node_binding/rspack.linux-x64-gnu.node"
+	).size;
+
+	const comment = compareBinarySize(headSize, baseSize, baseCommit);
+
+	await commentToPullRequest(github, context, comment);
+};
+
+async function commentToPullRequest(github, context, comment) {
+	const { data: comments } = await github.rest.issues.listComments({
+		owner: context.repo.owner,
+		repo: context.repo.repo,
+		issue_number: context.payload.number
+	});
+
+	const prevComment = comments.filter(
+		comment =>
+			comment.user.login === "github-actions[bot]" &&
+			comment.body.startsWith(SIZE_LIMIT_HEADING)
+	)[0];
+
+	if (prevComment) {
+		await github.rest.issues.updateComment({
+			owner: context.repo.owner,
+			repo: context.repo.repo,
+			comment_id: prevComment.id,
+			body: `${SIZE_LIMIT_HEADING}\n${comment}`
+		});
+		return;
+	}
+
+	await github.rest.issues.createComment({
+		owner: context.repo.owner,
+		repo: context.repo.repo,
+		issue_number: context.payload.number,
+		body: `${SIZE_LIMIT_HEADING}\n${comment}`
+	});
+}
+
+function fetchDataBySha(sha) {
+	const dataUrl = `${DATA_URL_BASE}/commits/${sha.slice(0, 2)}/${sha.slice(2)}/rspack-build.json`;
+	console.log("fetching", dataUrl, "...");
+	return fetch(dataUrl).then(res => res.json());
+}
+
+const SIZE_LIMIT_HEADING = "## 📦 Binary Size-limit";
+
+const DATA_URL_BASE =
+	"https://raw.githubusercontent.com/web-infra-dev/rspack-ecosystem-benchmark/data";
+
+function compareBinarySize(headSize, baseSize, baseCommit) {
+	const message = baseCommit.commit.message.split("\n")[0];
+	const author = baseCommit.commit.author.name;
+
+	const info = `> Comparing binary size with Commit: [${message} by ${author}](${baseCommit.html_url})\n\n`;
+
+	const diff = headSize - baseSize;
+	const percentage = (Math.abs(diff / baseSize) * 100).toFixed(2);
+	if (diff > 0) {
+		return `${info}❌ Size increased by ${toHumanReadable(diff)} from ${toHumanReadable(baseSize)} to ${toHumanReadable(headSize)} (⬆️${percentage}%)`;
+	}
+	if (diff < 0) {
+		return `${info}🎉 Size decreased by ${toHumanReadable(-diff)} from ${toHumanReadable(baseSize)} to ${toHumanReadable(headSize)} (⬇️${percentage}%)`;
+	}
+	return `${info}🙈 Size remains the same at ${toHumanReadable(headSize)}`;
+}
+
+function toHumanReadable(size) {
+	if (size < 1024) {
+		return `${size}bytes`;
+	}
+	if (size < 1024 * 1024) {
+		return `${(size / 1024).toFixed(2)}KB`;
+	}
+	return `${(size / 1024 / 1024).toFixed(2)}MB`;
+}

.github/workflows/ci-rust.yaml

@@ -18,112 +18,9 @@ on:
     tags-ignore:
       - "**"
 jobs:
-  check-changed:
-    runs-on: ubuntu-latest
-    name: Check Source Changed
-    outputs:
-      code_changed: ${{ steps.filter.outputs.code_changed == 'true' }}
-      document_changed: ${{ steps.filter.outputs.document_changed == 'true' }}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
-        id: filter
-        with:
-          predicate-quantifier: "every"
-          filters: |
-            code_changed:
-              - "!**/*.md"
-              - "!**/*.mdx"
-              - "!website/**"
-            document_changed:
-              - "website/**"
-  rust_check:
-    name: Rust check
-    needs: [check-changed]
-    if: ${{ needs.check-changed.outputs.code_changed == 'true' }}
-    runs-on: ${{ fromJSON(vars.LINUX_SELF_HOSTED_RUNNER_LABELS ||  '"ubuntu-22.04"') }}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-
-      - name: Install Rust Toolchain
-        uses: ./.github/actions/rustup
-        with:
-          save-if: true
-          key: check
-
-      - name: Run Cargo Check
-        run: cargo check --workspace --all-targets --locked # Not using --release because it uses too much cache, and is also slow.
-
-      - name: Run Clippy
-        uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
-        with:
-          command: clippy
-          args: --workspace --all-targets --tests -- -D warnings
-
-      - name: Run rustfmt
-        uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
-        with:
-          command: fmt
-          args: --all -- --check
-
-      - name: Install tapo
-        run: cargo install taplo-cli --locked
-      - name: Run toml format check
-        run: taplo format --check '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'
-
-  rust_unused_dependencies:
-    needs: [check-changed]
-    if: ${{ needs.check-changed.outputs.code_changed == 'true' }}
-    name: Check Rust Dependencies
-    runs-on: ${{ fromJSON(vars.LINUX_SELF_HOSTED_RUNNER_LABELS || '"ubuntu-22.04"') }}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-      - uses: ./.github/actions/rustup
-        with:
-          key: check
-
-      - name: Install cargo-deny
-        uses: taiki-e/install-action@726a5c9e4be3a589bab5f60185f0cdde7ed4498e # v2
-        with:
-          tool: [email protected]
-      - name: Check licenses
-        run: cargo deny check license bans
-
-      - uses: cargo-bins/cargo-binstall@8aac5aa2bf0dfaa2863eccad9f43c68fe40e5ec8 # v1.14.1
-      - run: cargo binstall --no-confirm [email protected] --force
-      - run: cargo shear
-
-  rust_test:
-    name: Rust test
-    runs-on: ${{ fromJSON(vars.LINUX_SELF_HOSTED_RUNNER_LABELS || '"ubuntu-22.04"') }}
-    needs: [check-changed]
-    if: ${{ needs.check-changed.outputs.code_changed == 'true' }}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-
-      - name: Install Rust Toolchain
-        uses: ./.github/actions/rustup
-        with:
-          save-if: true
-          key: test
-
-      # Compile test without debug info for reducing the CI cache size
-      - name: Change profile.test
-        shell: bash
-        run: |
-          echo '[profile.test]' >> Cargo.toml
-          echo 'debug = false' >> Cargo.toml
-      - name: Run rspack test
-        run: |
-          cargo test --workspace \
-            --exclude rspack_binding_api \
-            --exclude rspack_node \
-            --exclude rspack_binding_builder \
-            --exclude rspack_binding_builder_macros \
-            --exclude rspack_binding_builder_testing \
-            --exclude rspack_binding_build \
-            --exclude rspack_napi \
-            -- --nocapture
+  rust_tests:
+    name: Run Rust Tests
+    uses: ./.github/workflows/reusable-rust-test.yml
 
   rust_test_miri:
     name: Rust test miri
@@ -158,14 +55,14 @@ jobs:
     # When code changed, it will check if any of the test jobs failed.
     # When *only* doc changed, it will run as success directly
     name: Rust Test Required Check
-    needs: [rust_test, rust_check, check-changed]
+    needs: [rust_tests]
     if: ${{ always() && !cancelled() }}
     runs-on: ubuntu-latest
     steps:
       - name: Log
-        run: echo ${{ join(needs.*.result, ',') }}
+        run: echo ${{ needs.*.result }}
       - name: Test check
-        if: ${{ needs.check-changed.outputs.code_changed == 'true' && join(needs.*.result, ',')!='success,success,success' }}
-        run: echo "Tess Failed" && exit 1
+        if: ${{ needs.rust_tests.result != 'success' }}
+        run: echo "Tests Failed" && exit 1
       - name: No check to Run test
         run: echo "Success"

.github/workflows/ci.yml

@@ -28,6 +28,8 @@ concurrency:
 permissions:
   # Allow commenting on issues for `reusable-build.yml`
   issues: write
+  # Allow commenting on pull requests for `size-limit.yml`
+  pull-requests: write
 
 jobs:
   check-changed:
@@ -138,6 +140,12 @@ jobs:
       - name: No check to Run test
         run: echo "Success"
 
+  size-limit:
+    name: Binary Size Limit
+    needs: [check-changed]
+    if: ${{ needs.check-changed.outputs.code_changed == 'true' && github.event_name == 'pull_request' }}
+    uses: ./.github/workflows/size-limit.yml
+
   # TODO: enable it after self hosted runners are ready
   # pkg-preview:
   #   name: Pkg Preview

.github/workflows/release-crates.yml

@@ -0,0 +1,47 @@
+name: Release Crates
+
+on:
+  workflow_dispatch:
+    inputs:
+      dry_run:
+        type: boolean
+        description: "DryRun release"
+        required: true
+        default: false
+      push_tags:
+        type: boolean
+        description: "Push tags to repository"
+        required: true
+        default: true
+
+jobs:
+  rust_tests:
+    name: Run Rust Tests
+    uses: ./.github/workflows/reusable-rust-test.yml
+
+  release_crates:
+    environment: crate
+    name: Release Crates
+    runs-on: ubuntu-latest
+    needs: [rust_tests]
+    if: ${{ github.event_name == 'workflow_dispatch' }}
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+
+      - name: Install Rust Toolchain
+        uses: ./.github/actions/rustup
+        with:
+          save-if: true
+          key: release
+
+      - name: Install cargo-workspaces
+        run: cargo install cargo-workspaces --locked
+
+      - name: Publish Crates
+        run: |
+          ./x crate-publish --token $CARGO_REGISTRY_TOKEN ${{ inputs.dry_run && '--dry-run' || '' }} ${{ inputs.push_tags && '--push-tags' || '' }}
+        env:
+          CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}