-
Notifications
You must be signed in to change notification settings - Fork 214
Outdated Windows logo on Endpoints section #7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated Windows logo on Endpoints section #7712
Conversation
Signed-off-by: gonzaarancibia <[email protected]>
plugins/main/public/components/endpoints-summary/table/columns.tsx
Outdated
Show resolved
Hide resolved
TestLegend: UI
Details |
In a daily meeting, the related issue was discussed for unifying the render of icons: fontawesome vs image. |
plugins/main/public/components/endpoints-summary/table/columns.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/overview/components/overview-actions/agents-selection-table.js
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/welcome/agent-info/agent-info.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/endpoints-summary/table/columns.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/endpoints-summary/table/columns.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/endpoints-summary/table/agents-table.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/overview/components/overview-actions/agents-selection-table.js
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/overview/components/overview-actions/agents-selection-table.js
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/overview/components/overview-actions/agents-selection-table.js
Outdated
Show resolved
Hide resolved
…ogos Signed-off-by: gonzaarancibia <[email protected]>
…d font awesome Signed-off-by: gonzaarancibia <[email protected]>
The Prettier GHA is failing. |
plugins/main/public/components/common/welcome/agent-info/agent-info.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/groups/group-agents-table.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the comments.
Signed-off-by: gonzaarancibia <[email protected]>
Signed-off-by: gonzaarancibia <[email protected]>
Signed-off-by: gonzaarancibia <[email protected]>
Signed-off-by: gonzaarancibia <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: gonzaarancibia <[email protected]>
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test: 🟢
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Test | Chrome | Firefox | Safari |
---|---|---|---|
In Light theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table | 🟢 | 🟢 | ⚪ |
In Dark theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table | 🟢 | 🟢 | ⚪ |
Details
plugins/main/public/controllers/overview/components/overview-actions/agents-selection-table.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Update the old Windows icon to the new Windows 11 icon.
Issues Resolved
#7693
Evidence
Evidence
Test
Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table
.dark mode
.Check List
yarn test:jest