Skip to content

Conversation

gonzaarancibia
Copy link
Member

@gonzaarancibia gonzaarancibia commented Sep 8, 2025

Description

Update the old Windows icon to the new Windows 11 icon.

Issues Resolved

#7693

Evidence

Evidence

Screenshot 2025-09-08 at 8 07 38 AM Screenshot 2025-09-08 at 11 09 50 AM Screenshot 2025-09-12 at 10 44 09 AM Screenshot 2025-09-08 at 8 09 21 AM

Test

  • Verify that the old window icon are replaced by the new one on Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table.
  • Verify it renders correctly on dark mode.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: gonzaarancibia <[email protected]>
@gonzaarancibia gonzaarancibia self-assigned this Sep 8, 2025
@gonzaarancibia gonzaarancibia linked an issue Sep 8, 2025 that may be closed by this pull request
@Desvelao
Copy link
Member

Desvelao commented Sep 9, 2025

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
In Light theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table 🟢
In Dark theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table 🟢

Details

🟢 In Light theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table

Chrome - 🟢
image

image image image

Firefox - ⚫

Safari - ⚫

🟢 In Dark theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table

Chrome - 🟢
image

image image image

Firefox - ⚫

Safari - ⚫

@Desvelao
Copy link
Member

Desvelao commented Sep 9, 2025

In a daily meeting, the related issue was discussed for unifying the render of icons: fontawesome vs image.

@guidomodarelli
Copy link
Member

The Prettier GHA is failing.

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the comments.

@Desvelao
Copy link
Member

Desvelao commented Sep 12, 2025

Some views working

image image image image image

@guidomodarelli

This comment was marked as off-topic.

@guidomodarelli
Copy link
Member

guidomodarelli commented Sep 15, 2025

🧪 UI Tests

Test Description Chrome
1️⃣ In Agents management > Summary: Select an agent → Hover over the operating system on the top banner → Inside the popover → The OS logo should be aligned with the text and displayed in white for better contrast 🔴
2️⃣ In Agents management > Summary: Open the view → Verify the agents table is showing the correct agent logo 🟢
3️⃣ In Agents management > Summary: Select an agent from the table → Verify the top banner appears → The banner should render the selected agent’s logo 🟢
4️⃣ In Agents management > Summary: Select an agent from the table → Click the top-right button to change the selected agent → A popup should open showing a selectable table of agents → This table should render a list of agents with their respective agent logos 🟢

📋Test Details

🔴 1️⃣ In **Agents management > Summary**: Select an agent → Hover over the operating system on the top banner → Inside the popover → The OS logo should be aligned with the text and displayed in white for better contrast

CHROME - 🔴
The OS popover must show the logo aligned with its text, in white, ensuring proper contrast with the background.

image image image

Dark Mode 🟢

image image image
🟢 2️⃣ In **Agents management > Summary**: Open the view → Verify the agents table is showing the correct agent logo

CHROME - 🟢
Each agent row should render the correct logo, consistent with the agent’s operating system.

image

Dark Mode 🟢

image
🟢 3️⃣ In **Agents management > Summary**: Select an agent from the table → Verify the top banner appears → The banner should render the selected agent’s logo

CHROME - 🟢
The banner must include the agent’s logo next to the name and status, without distortion or spacing issues.

image

Dark Mode 🟢

image
🟢 4️⃣ In **Agents management > Summary**: Select an agent from the table → Click the top-right button to change the selected agent → A popup should open showing a selectable table of agents → This table should render a list of agents with their respective agent logos

CHROME - 🟢
The popup must display a table where each agent row includes the correct logo; logos should be properly aligned and sized consistently.

image

Dark Mode 🟢

image

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 48.3% ( 443 / 917 )
Branches 43.9% ( 173 / 394 )
Functions 44.81% ( 147 / 328 )
Lines 48.45% ( 440 / 908 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 18.27% ( 5678 / 31062 )
Branches 12.7% ( 2510 / 19751 )
Functions 19.27% ( 1459 / 7568 )
Lines 18.47% ( 5523 / 29892 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
In Light theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table 🟢 🟢
In Dark theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table 🟢 🟢

Details

🟢 In Light theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table

Chrome - 🟢

Image Image Image Image

Firefox - 🟢

Image Image Image Image
🟢 In Dark theme, review the Windows icon changed in Deploy new agent, Agent welcome, explore agent select popup, endpoints summary agent table

Chrome - 🟢

Image Image Image Image

Firefox - 🟢

Image Image Image Image

Safari - ⚫

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit f26de7b into 4.14.0 Sep 16, 2025
5 checks passed
@asteriscos asteriscos deleted the bug/7693-outdated-windows-logo-on-endpoints-section branch September 16, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Windows logo on Endpoints section
4 participants