Adapt dashboard components to self-control requirement failures #7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed due to missing data
…ted to server API down
…and throw error if there is no information about the selected API
…lete useless code This way, each section—Server APIs, App Settings, About, and Sample Data—manages its own requests, loaders, and errors. It also avoids unnecessary requests on every section render. Signed-off-by: gonzaarancibia <[email protected]>
…g-requirements' of https://github.com/wazuh/wazuh-kibana-app into enhancement/7680-rework-healthcheck-manage-error-missing-requirements
…problems with that
🟡 Observations
I saw several comments with TODO or WORKAROUND, and I’m not sure if that’s okay. It will be fixed later, but I just wanted to leave it as an observation. |
Co-authored-by: Guido Modarelli <[email protected]>
…g-requirements' of https://github.com/wazuh/wazuh-kibana-app into enhancement/7680-rework-healthcheck-manage-error-missing-requirements
|
|
|
|
For now, we will not do the suggestion related to i18n. |
| } catch {} | ||
| return await selector.getAllDataSources(); | ||
| } | ||
|
|
||
| const WzDataSourceSelector = ( | ||
| props: tWzDataSourceSelector<tParsedIndexPattern, PatternDataSource>, |
There was a problem hiding this comment.
Suggested change
| props: tWzDataSourceSelector<tParsedIndexPattern, PatternDataSource>, | |
| props: tWzDataSourceSelector<tParsedIndexPattern>, |
| </EuiFormRow> | ||
| <SelectorContainer> | ||
| <SelectorLabel | ||
| actionError={actionError} |
There was a problem hiding this comment.
Suggested change
| actionError={actionError} | |
| actionError={actionError ? actionError : undefined} |
|
|
||
| This logic could be moved to another service. | ||
| */ | ||
| export async function AlertsDataSourceSetup() { |
There was a problem hiding this comment.
You could move this to another file, called AlertsDataSourceSetup, or simply Setup. That way it doesn’t get mixed up with the file name, which is AlertsDataSourceRepository.ts. This keeps things better organized, without mixing concepts in the same file.
|
🔴 The ESlint Action is falling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds enhancements to self-control the requirement by view/panels depending on the case.
withDataSourceInitiatedHOCEventsCountcomponentuseDataSourcehook when setting filters/settingspath to decouple the requirements/blank-screenroute, related UI component and dependenciessettingsWizardroute resolverIssues Resolved
#7680
Evidence
Test
See #7680 (comment)
Check List
yarn test:jest