Skip to content

Conversation

JiaZhou-PU
Copy link
Contributor

@JiaZhou-PU JiaZhou-PU commented Apr 22, 2025

Description

Add A-LEAF plugin and include one example of A-LEAF in example folder
The plugin supports automated modification and execution of ALEAF Fuel prices via parameterized input templates and dynamically modifies ALEAF_Master_LC_GTEP.xlsx based on WATTS parameters.

Since A-LEAF is still under active development, future support is planned to modify ALEAF inputs in the prerun step based on ALEAF updates.

Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have updated the CHANGELOG.md file (if applicable)
  • I have successfully run examples that may be affected by my changes

@JiaZhou-PU JiaZhou-PU marked this pull request as ready for review April 22, 2025 20:34
@JiaZhou-PU
Copy link
Contributor Author

@nstauff ready for review

@nstauff nstauff requested a review from paulromano April 22, 2025 20:35
Copy link
Contributor

@nstauff nstauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JiaZhou-PU - main comment is to improve the test leveraging more advanced Jinja templating technique that can take list or dictionary. That will make your test/tutorial model much cleaner.

@JiaZhou-PU
Copy link
Contributor Author

Updated the templating in the example and tests using the Jinja template. @nstauff

@nstauff
Copy link
Contributor

nstauff commented Apr 24, 2025

@paulromano - this is ready for your review.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JiaZhou-PU and good to see the A-LEAF plugin finally materialize. A few comments for you below:

@JiaZhou-PU
Copy link
Contributor Author

@paulromano comments addressed; ready for review.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now; thanks @JiaZhou-PU!

@paulromano paulromano merged commit ecfc6c9 into watts-dev:development May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants