Skip to content

fixup algs contd 3 #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Oct 19, 2017
Merged

fixup algs contd 3 #498

Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
ed25b6c
do not call authenticatorMakeCredential() with separate |rpId| fixes …
Jun 16, 2017
31a8f85
credID returned by authnrGetAssn() is optional if allowCreds has exac…
Jun 16, 2017
9c3940f
fixup global object reference per domenic, improves #472
Jun 20, 2017
be43665
indent 4.1.4 step 18et al to clarify relation to prior step
Jun 28, 2017
9ce4331
fix line indent
Jun 28, 2017
78d6d2c
Merge branch 'master' into jeffh-fixup-algs-contd-3
Jul 5, 2017
9ddf29d
Merge branch 'master' into jeffh-fixup-algs-contd-3
Aug 4, 2017
5f543b8
do not call authenticatorMakeCredential() with separate |rpId| fixes …
Jun 16, 2017
d8fd53b
credID returned by authnrGetAssn() is optional if allowCreds has exac…
Jun 16, 2017
c9b40d5
fixup global object reference per domenic, improves #472
Jun 20, 2017
d492a50
indent 4.1.4 step 18et al to clarify relation to prior step
Jun 28, 2017
2934f9e
fix line indent
Jun 28, 2017
a1be0f6
post rebase-on-master, fix dangling MakeCredentialOptions
Aug 18, 2017
28f52af
fix error in resolving rebase conflicts
Aug 18, 2017
5fada18
further rebase conflict resolution error fixups
Aug 18, 2017
6a011d2
merge with this remote branch via pull, somehow they were out of sync
Aug 18, 2017
5fb2f8c
convert switch steps to colon-denotation
Aug 22, 2017
51706b3
tag 'while'
Aug 24, 2017
5e4a7b0
primary changes for improving #472 mostly complete
Aug 25, 2017
d6d6c19
further issue #472 cleanups
Aug 25, 2017
a76de0b
del 'cancel the timer' from #creatCredential fixes #535
Aug 25, 2017
97f0ae2
polish constructResultantCredentialCallback method description
Aug 25, 2017
1f096de
incorp comments from mikewest at webappsec-credential-management/pull…
Sep 8, 2017
ae91fa0
rebased onto master
Sep 29, 2017
79cff12
credID returned by authnrGetAssn() is optional if allowCreds has exac…
Jun 16, 2017
5fef555
fixup global object reference per domenic, improves #472
Jun 20, 2017
d55a65f
indent 4.1.4 step 18et al to clarify relation to prior step
Jun 28, 2017
33bee9e
fix line indent
Jun 28, 2017
9872f1a
do not call authenticatorMakeCredential() with separate |rpId| fixes …
Jun 16, 2017
de00dfb
credID returned by authnrGetAssn() is optional if allowCreds has exac…
Jun 16, 2017
8dc2fe6
post rebase-on-master, fix dangling MakeCredentialOptions
Aug 18, 2017
1f7a9c6
fix error in resolving rebase conflicts
Aug 18, 2017
8aeb8ed
convert switch steps to colon-denotation
Aug 22, 2017
b6cf922
tag 'while'
Aug 24, 2017
ef7b69d
primary changes for improving #472 mostly complete
Aug 25, 2017
f5d75fe
further issue #472 cleanups
Aug 25, 2017
68ecbce
polish constructResultantCredentialCallback method description
Aug 25, 2017
598c347
incorp comments from mikewest at webappsec-credential-management/pull…
Sep 8, 2017
fb25968
rebase onto master
Sep 29, 2017
a1b998f
fix indents make BS happy, add some periods
Sep 30, 2017
7b0d9a8
fix code tags placement
Oct 3, 2017
f55f8a3
merge from master
Oct 5, 2017
81a8921
correct bugs in prior merge conflict resolution, doh
Oct 5, 2017
7e06037
rm 'the bytes of'
Oct 6, 2017
004c45a
merge from master
Oct 11, 2017
3d771c2
add missing @@EDITOR-ANCHOR-01A
Oct 11, 2017
622d11a
auto-number some steps
Oct 11, 2017
8fe61c6
merge from master fix conflicts
Oct 13, 2017
a8799aa
re- fix #466 (due to merge-from-master), fix #536
Oct 13, 2017
f5a08fb
eliminate callback and just return an algorithm from #createCredential
Oct 13, 2017
7b272f1
merge from master
Oct 16, 2017
6f51ef6
merge from master
Oct 17, 2017
928f83b
merge from master
Oct 18, 2017
3d84d14
continue fix conflicts from merge from master
Oct 18, 2017
9d1db3a
fix a couple of issue #466 stragglers in #op-make-cred
Oct 18, 2017
7e035e9
revert to prior AuthenticationExtensions language per jyasskin
Oct 19, 2017
dbee092
add inline spec issue pointing to issue #657
Oct 19, 2017
942e7b4
minor cleanups, remove issue wrt not explicitly returning |credential…
Oct 19, 2017
32e2eb6
fix annoying bikeshed warning wrt 'rpEntity'
Oct 19, 2017
4b2193e
correctly fix warning as well as other incorrect markup
Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading