Skip to content

Remove single-value AttributionLogic enum and inline credit field #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Remove single-value AttributionLogic enum and inline credit field #276

merged 3 commits into from
Sep 12, 2025

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Sep 10, 2025 •
edited by pr-preview bot
Loading

Fixes #275

Preview | Diff

martinthomson
martinthomson reviewed Sep 10, 2025
View reviewed changes
martinthomson
martinthomson reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good direction. I'm not sure that we even need to replace the enum if we do the programmatic attribution thing.

apasel422 and others added 2 commits September 11, 2025 08:23
@apasel422 apasel422 marked this pull request as ready for review September 11, 2025 12:30
@apasel422 apasel422 mentioned this pull request Sep 11, 2025
Merged
martinthomson
martinthomson approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@apasel422 apasel422 merged commit 231e32b into w3c:main Sep 12, 2025
3 checks passed
@apasel422 apasel422 deleted the simplify-conv branch September 12, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@csharrison csharrison Awaiting requested review from csharrison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider simplifying AttributionConversionOptions for initial iteration of API
2 participants
@apasel422 @martinthomson