-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
fix(compiler-sfc): add support for @vue-ignore
in runtime type resolution
#13906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds an ignore pre-check in runtime type inference to return Unknown when a node has a leading "@vue-ignore" comment, and extends tests with a case covering TypeScript property signatures using the ignore marker. No public APIs changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant TS as TS Node
participant RT as inferRuntimeType
participant R as Resolver
Note over TS,RT: Node may have a leading comment
RT->>TS: Inspect leading comments
alt Has "@vue-ignore"
RT-->>R: Return [UNKNOWN_TYPE] (skip inference)
else No ignore
RT->>R: Proceed with normal type inference
R-->>RT: Inferred runtime type(s)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
@vue-ignore
in runtime type resolution@vue-ignore
in runtime type resolution
Playground
Summary by CodeRabbit
New Features
Bug Fixes
Tests