[Bugfix] Fix incompatibility between #20452 and #24548 #24754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#24528 Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
requested review from
WoosukKwon,
robertgshaw2-redhat and
njhill
as code owners
DarkLight1337
added
the
ready
DarkLight1337
requested review from
ywang96,
comaniac and
alexm-redhat
as code owners
7 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request resolves an incompatibility bug within the v1 executor's handling of multi-modal inputs. The change correctly updates the logic to use the mm_features attribute instead of the outdated mm_kwargs, and provides the proper identifier for cache lookups. This aligns the implementation with recent data structure changes and ensures that multi-modal data is correctly retrieved from the shared memory cache.
Signed-off-by: DarkLight1337 <[email protected]>
|
Oops, yeah, let me fix the typo |
DarkLight1337
changed the title
5 tasks
mgoin
approved these changes
Sep 12, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]>
BoyuanFeng
pushed a commit
to BoyuanFeng/vllm
that referenced
this pull request
Sep 14, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Sep 15, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: bbartels <[email protected]>
cboss6
pushed a commit
to cboss6/vllm
that referenced
this pull request
Sep 16, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: bruceszchen <[email protected]>
cboss6
pushed a commit
to cboss6/vllm
that referenced
this pull request
Sep 16, 2025
…ect#24548 (vllm-project#24754) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: bruceszchen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix incompatibility between #20452 and #24528
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.