Skip to content

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Aug 9, 2024

Description

The 14.2-rc package can't be installed because the generate:tsconfig script can't run. The issue is caused by the postinstall script that runs when the package is installed from npm. We don't ship any of our devops files which makes the script fail.

How to test

You can test a local version of the package to check that it installs correctly:

In the backoffice repo

  1. npm i to ensure all dependencies are installed
  2. npm run build:for:npm build the output files for npm
  3. npm pack pack a local version of the npm package
  4. Copy the package to a local Umbraco project where it should be installed

In your Umbraco project

  1. Point to the local version in your package.json file: "@umbraco-cms/backoffice": "./umbraco-cms-backoffice-14.2.0.tgz"
  2. Run npm i in your Umbraco project
  3. 🤞 The package works

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title Remove postinstall script Chore: Remove postinstall script Aug 9, 2024
Copy link

sonarqubecloud bot commented Aug 9, 2024

@madsrasmussen madsrasmussen marked this pull request as ready for review August 9, 2024 10:11
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants