Ensure that TaskScheduler.Default is used anywhere that ContinueWith is used, adds more debug logging to MainDom operations #9408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used, adds more debug logging to MainDom operations
bergmania
reviewed
Nov 22, 2020
bergmania
approved these changes
Nov 23, 2020
nul800sebastiaan
pushed a commit
that referenced
this pull request
Dec 15, 2020
…m-logging Ensure that TaskScheduler.Default is used anywhere that ContinueWith is used, adds more debug logging to MainDom operations (cherry picked from commit 9a1b456) # Conflicts: # src/Umbraco.Core/Runtime/SqlMainDomLock.cs
|
Cherry picked for 8.6 and above as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that TaskScheduler.Default is used anywhere that ContinueWith is used and adds more debug logging to MainDom operations.
ContinueWith should always have
TaskScheduler.Defaultexplicitly declared. There's a few instances in the codebase where this is not the case. It hasn't caused problems in the past that we know about but it is the safe thing to do. For more reading see https://blog.stephencleary.com/2013/10/continuewith-is-dangerous-too.htmlThis adds a little bit more debug logging to MainDom. This is for debugging purposes only because there's one known site where MainDom shuts down without the application being shutdown and without any SqlMainDomLock logging taking place which is truly odd.
Testing