Skip to content

Fixed and improved currentsapi detector #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

Fixed and improved currentsapi detector #4391

merged 3 commits into from
Aug 13, 2025

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Aug 13, 2025 •
edited
Loading

Description:

This PR fixes the CurrentsAPI detector:

  • The original regex was too broad due to the use of \S. It has been optimized to use [A-Za-z0-9_-], as CurrentsAPI tokens only contain alphanumeric characters, underscores, and hyphens.
  • After generating and testing 25+ tokens, I found that they can start or end with - or _, so the word boundary (\b) had to be removed.
  • The verification logic has been separated for clarity, and status code handling has been improved.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner August 13, 2025 07:15
amanfcp
amanfcp reviewed Aug 13, 2025
View reviewed changes
@amanfcp amanfcp merged commit 134a599 into trufflesecurity:main Aug 13, 2025
13 checks passed
@blsaccess blsaccess mentioned this pull request Aug 15, 2025
Merged
@kashifkhan0771 kashifkhan0771 deleted the update/oss-56-currentsapi branch August 15, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanfcp amanfcp amanfcp approved these changes

@shahzadhaider1 shahzadhaider1 shahzadhaider1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashifkhan0771 @amanfcp @shahzadhaider1