Skip to content

Conversation

casey-tran
Copy link
Contributor

@casey-tran casey-tran commented Aug 12, 2025

Description:

Update the proto definitions found for Bitbucket sources to have OAuth option in the config file. Also regenerated the Protobuf files with the changes.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@casey-tran casey-tran marked this pull request as ready for review August 12, 2025 22:37
@casey-tran casey-tran requested review from a team as code owners August 12, 2025 22:37
Copy link
Contributor

@martinlocklear martinlocklear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but it would be nice if there was some inline documentation here about what these fields are for. The commit message also isn't entirely accurate right? Seems like you're adding fields and regenerating protos.

@casey-tran casey-tran merged commit 0f58ae7 into main Aug 14, 2025
13 checks passed
@casey-tran casey-tran deleted the custom-bitbucket-oauth-2 branch August 14, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants