Improved and fixed couchbase detector #4383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves and fixes the Couchbase detector.
Improvements:
Fixes:
meetsCouchbasePasswordRequirements
function had a bug: it returned the password as soon as all character requirements were met, without validating the entire string. For example, given the passwordAB-1aiop
, it would incorrectly returnAB-1a
. The logic has now been corrected to validate the full string and updated to return only a boolean.Raw
field previously combined all three matches (connection string, username, and password), which could cause issues for the engine when trying to determine the line number. To address this, the connection string has been set as the primary secret to improve line number detection by the engine.Checklist:
make test-community
)?make lint
this requires golangci-lint)?