Skip to content

Conversation

camgunz
Copy link
Contributor

@camgunz camgunz commented Jul 22, 2025

Description:

This adds new protobuf messages used by a new Slack Continuous source in enterprise

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@camgunz camgunz requested review from a team as code owners July 22, 2025 14:13
Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be called SlackRealtime?

@camgunz
Copy link
Contributor Author

camgunz commented Jul 23, 2025

Should it be called SlackRealtime?

Good Q! Martin and Shani put their heads together and IIRC while the external name is "Slack Realtime" it's a little confusing to use that name on our end because of the existing Source. I'm... pretty sure that's all correct; to be honest Martin told me to use "Continuous" and I've since defenestrated all of the underlying reasoning out of my brain.

@camgunz camgunz merged commit 227d92c into main Jul 23, 2025
12 checks passed
@camgunz camgunz deleted the add-slack-continuous-protobuf-messages branch July 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants