Skip to content

Oss 248 refactor y alphabet detectors #4293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Oss 248 refactor y alphabet detectors #4293

wants to merge 16 commits into from

Conversation

SyedAliHamad
Copy link
Contributor

@SyedAliHamad SyedAliHamad commented Jul 7, 2025 •
edited
Loading

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@SyedAliHamad SyedAliHamad marked this pull request as ready for review July 7, 2025 21:53
@SyedAliHamad SyedAliHamad requested a review from a team as a code owner July 7, 2025 21:53
kashifkhan0771
kashifkhan0771 requested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code, looks good to me. I added few comments.

@amanfcp amanfcp mentioned this pull request Aug 13, 2025
Closed
2 tasks
@amanfcp
Copy link
Contributor

amanfcp commented Aug 15, 2025

Contributes to #4051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanfcp amanfcp amanfcp left review comments

@kashifkhan0771 kashifkhan0771 kashifkhan0771 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyedAliHamad @amanfcp @kashifkhan0771