[Update] Dovico Detector Updated #4290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadhaider1
approved these changes
Jul 4, 2025
abmussani
reviewed
Jul 7, 2025
|
|
||
| s1 := detectors.Result{ | ||
| DetectorType: detectorspb.DetectorType_Dovico, | ||
| Raw: []byte(resMatch), | ||
| Raw: []byte(key), |
There was a problem hiding this comment.
Shouldn't RAW contain both key + userkey ? or may be set RawV2 for both keys? Otherwise, it will be difficult to find which combination worked.
There was a problem hiding this comment.
Could changing the Raw value have an impact on existing usage of this detector? Same question about adding a RawV2 value?
I can make those updates if this is a safe option.
There was a problem hiding this comment.
umm.... Considering only OSS, I could not think of any impact. @trufflesteeeve what are your thoughts.
There was a problem hiding this comment.
@abmussani I added a RawV2 value
kashifkhan0771
approved these changes
Jul 7, 2025
abmussani
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The ID and secret patterns are the same. This update adds a check to avoid verification of identical credential pairs.
Also removes duplicate credentials and adds indeterminate verification errors in results.
Checklist:
make test-community)?make lintthis requires golangci-lint)?