Skip to content

Updated ExchangeRate Detector #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Updated ExchangeRate Detector #4278

merged 1 commit into from
Jun 30, 2025

Conversation

kashifkhan0771
Copy link
Contributor

Description:

This PR includes the following updates to the ExchangeRateAPI Detector:

  • Refined the regular expression for improved accuracy.
  • Expanded and updated the list of keywords.
  • Enhanced security by moving the authentication key from the URL path to the request header only.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner June 30, 2025 10:32
nabeelalam
nabeelalam approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@nabeelalam nabeelalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kashifkhan0771 kashifkhan0771 merged commit 9a99973 into trufflesecurity:main Jun 30, 2025
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the update/oss-244 branch June 30, 2025 12:48
@blsaccess blsaccess mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeelalam nabeelalam nabeelalam approved these changes

@shahzadhaider1 shahzadhaider1 shahzadhaider1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashifkhan0771 @nabeelalam @shahzadhaider1