Skip to content

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Jun 23, 2025

This directory holds only detector information, but it's in /engine, so its codeownership has been incorrectly assigned to non-OSS teams. Moving it to a detector-related spot created an import cycle that I don't want to deal with right now, so instead I'm just tweaking CODEOWNERS.

Description:

Explain the purpose of the PR.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

This directory holds only detector information, but it's in `/engine`, so its codeownership has been incorrectly assigned to non-OSS teams. Moving it to a detector-related spot created an import cycle that I don't want to deal with right now, so instead I'm just tweaking CODEOWNERS.
@rosecodym rosecodym requested a review from a team as a code owner June 23, 2025 20:50
@rosecodym rosecodym requested review from a team June 23, 2025 20:50
Copy link
Contributor

@martinlocklear martinlocklear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@zricethezav zricethezav merged commit 5f8a6b1 into main Jun 24, 2025
13 checks passed
@zricethezav zricethezav deleted the default-detector-oss-ownership branch June 24, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants