Fix sqlserver detector #4200
Merged
Fix sqlserver detector #4200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
approved these changes
Jun 3, 2025
|
Thank you @shahzadhaider1 for creating issue on their end and for continued follow ups 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
go-mssqldblibrary from versionv1.8.0tov1.8.2to resolve an issue in the SQL Server detector.The previous version of the driver was unable to correctly parse the PWD field in connection strings, causing the detector to skip secrets where passwords were specified using the PWD key.
By upgrading to
v1.8.2, which includes a fix for this parsing issue, the detector can now accurately process and detect secrets containing PWD.Checklist:
make test-community)?make lintthis requires golangci-lint)?