Skip to content

Conversation

lonmarsDev
Copy link
Contributor

Description:

Explain the purpose of the PR.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@zricethezav
Copy link
Collaborator

We might want to rename this as flyiopersonalaccesstoken since fly.io also has organization tokens (see https://fly.io/docs/flyctl/tokens-create-org/ and https://fly.io/dashboard/{user_id}/tokens). Alternatively we could just leave this as flyio and use flyioorgtoken for the organizational token detector when we get to that.

@amanfcp amanfcp assigned amanfcp and unassigned amanfcp Jun 3, 2025
@amanfcp amanfcp added the pkg/detectors PRs and Issues related to the `detectors` package label Jun 3, 2025
@amanfcp amanfcp requested a review from a team as a code owner June 25, 2025 11:42
@amanfcp
Copy link
Contributor

amanfcp commented Jun 25, 2025

Hey @lonmarsDev, thanks for the contribution.

Can you please follow this document to follow conventions of adding a new detector?

amanfcp added 5 commits June 26, 2025 13:43
- Adjusted regex patterns for token matching
- Introduced a new Fly.io secret detector with functionality to identify and verify Fly.io tokens.
- Implemented integration tests to validate the detection and verification logic, including handling of false positives.
- Updated existing Fly.io test cases to enhance coverage and accuracy.
- Added logic to bypass common false positive checks for valid tokens.
@amanfcp amanfcp requested a review from zricethezav July 2, 2025 12:46
Copy link
Contributor

@nabeelalam nabeelalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @amanfcp !

@amanfcp amanfcp requested a review from kashifkhan0771 August 21, 2025 10:31
@kashifkhan0771 kashifkhan0771 merged commit 36f7be0 into trufflesecurity:main Aug 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/detectors PRs and Issues related to the `detectors` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants