bugfix: compare distribution names by parsed forms #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error introduced with #124 -- that PR correctly dropped our "ultranormalization" of distribution names, but it didn't account for the fact that we were comparing distribution names as strings, rather than as parsed forms. See pypa/gh-action-pypi-publish#365 for more context. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Jun 3, 2025
| def test_verify_different_wheel_tag_order(self) -> None: | ||
| attestation_path = ( | ||
| _ASSETS | ||
| / "spt3g-1.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.publish.attestation" # noqa: E501 |
There was a problem hiding this comment.
NB: This isn't the actual attestation from this package; I've re-signed the artifact with my own identity from the Sigstore staging instance for this test.
facutuesca
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error introduced with #124 -- that PR correctly dropped our "ultranormalization" of distribution names, but it didn't account for the fact that we were comparing distribution names as strings, rather than as parsed forms.
See pypa/gh-action-pypi-publish#365 for more context.